Python: fix(python): handle function_invocation_configuration in as_agent#5150
Open
saschabuehrle wants to merge 1 commit intomicrosoft:mainfrom
Open
Python: fix(python): handle function_invocation_configuration in as_agent#5150saschabuehrle wants to merge 1 commit intomicrosoft:mainfrom
saschabuehrle wants to merge 1 commit intomicrosoft:mainfrom
Conversation
github-actions
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4985
BaseChatClient.as_agent()acceptedfunction_invocation_configurationbut forwarded it toAgent(...), which no longer has that constructor argument. That produced aTypeError.This change keeps
as_agent()compatible by applying the provided config to the client-level function invocation configuration when available, and then creating the agent without unsupported kwargs.Also adds a regression test to verify that
as_agent(function_invocation_configuration=...)updates the client config without raising.Greetings, saschabuehrle