Repository navigation
Batch allocations of common checker types - #64776
Merged
Jake Bailey (jakebailey) merged 0 commit intoOct 13, 2026
Merged
Jake Bailey (jakebailey) merged 0 commit into
Jake Bailey (jakebailey) merged 0 commit into
Conversation
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Jake Bailey (jakebailey)
added this pull request to stack #64792
October 13, 2026 17:37
Jake Bailey (jakebailey)
changed the title
Jake Bailey (jakebailey)
changed the title
Jake Bailey (jakebailey)
marked this pull request as ready for review
October 13, 2026 17:42
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The mechanical allocation changes preserve type initialization and lifetime semantics without identified correctness issues.
0 open findings
What changed in this PR
This PR reduces checker allocation overhead by using typed arenas for common type records.
Changes:
- Adds ten type-specific arenas to
Checker. - Routes common type constructors through arena allocation.
| File | Description |
|---|---|
tsc/internal/checker/checker.go |
Adds and uses arenas for frequently allocated checker types. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
force-pushed
the
jakebailey/mem/batched-type-allocs
branch
from
October 13, 2026 20:06
49e3c55 to
6ae11db
Compare
Jake Bailey (jakebailey)
deleted the
jakebailey/mem/batched-type-allocs
branch
October 13, 2026 20:06
Jake Bailey (jakebailey)
restored the
jakebailey/mem/batched-type-allocs
branch
October 13, 2026 20:14
Jake Bailey (jakebailey)
deleted the
jakebailey/mem/batched-type-allocs
branch
October 14, 2026 01:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common type representations create many small heap objects during checking.
Part of the memory optimization stack summarized in #64734.