Repository navigation
Port missing keyof simplification for generic mapped types with name types - #64772
Merged
Jake Bailey (jakebailey) merged 3 commits intoOct 13, 2026
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the established simplification behavior and includes focused regression coverage.
0 open findings
What changed in this PR
Ports the missing keyof simplification for generic remapped mapped types, resolving TS2536 from #64768.
Changes:
- Simplifies index types for eligible generic mapped types.
- Adds regression coverage and updates affected baselines.
| File | Description |
|---|---|
tsc/internal/checker/checker.go |
Implements index-type simplification. |
tsc/testdata/tests/cases/compiler/mappedTypeAsClauseIntersectionConstraintIndexedAccess.ts |
Adds regression cases. |
tsc/testdata/baselines/reference/compiler/mappedTypeAsClauseIntersectionConstraintIndexedAccess.types |
Records inferred types. |
tsc/testdata/baselines/reference/compiler/mappedTypeAsClauseIntersectionConstraintIndexedAccess.symbols |
Records resolved symbols. |
tsc/testdata/baselines/reference/conformance/mappedTypeConstraints2.errors.txt |
Updates changed diagnostic detail. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #64768
this PR corrects the misported microsoft/typescript-go#2750