Repository navigation
Fix broken augmentExportEquals2 test fixture - #64748
Open
MaheshDesu (mahesh-desu) wants to merge 2 commits into
Open
MaheshDesu (mahesh-desu) wants to merge 2 commits into
MaheshDesu (mahesh-desu) wants to merge 2 commits into
Conversation
The fixture had a consecutive duplicate `// @filename: file3.ts` directive, which caused the test harness to save an empty file3.ts unit and wipe the content-bearing one. The test silently expected zero errors instead of the classic TS2671 + TS2503 diagnostics. Removing the duplicate line restores the expected behavior, matching the classic 5.9/6.0 baselines exactly. Refs microsoft#63814. Signed-off-by: MaheshDesu <mahesh.desu3@gmail.com>
typescript-automation
Bot
added
For Uncommitted Bug
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The fixture correction is consistent with all regenerated baselines and introduces no unresolved issues.
0 open findings
What changed in this PR
Repairs the augmentExportEquals2 compiler fixture so all three source files are tested and expected diagnostics are restored.
Changes:
- Removes the duplicate
file3.tsdirective. - Updates emit, type, symbol, and diagnostic baselines.
| File | Description |
|---|---|
augmentExportEquals2.ts |
Removes duplicate filename directive. |
augmentExportEquals2.errors.txt |
Adds expected diagnostics. |
augmentExportEquals2.js |
Updates emitted JavaScript baseline. |
augmentExportEquals2.types |
Updates type baseline. |
augmentExportEquals2.symbols |
Updates symbol baseline. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64927.
The
augmentExportEquals2conformance test fixture had a consecutive duplicate// @filename: file3.tsdirective (line 18). The test harness saves the previous unit with empty content when it encounters a new@filenamedirective, then re-opens the same name — so the content-bearingfile3.tswas wiped and the test silently expected zero errors.Classic TypeScript (5.9.3 / 6.0) expects:
Change: remove the duplicate
// @filename: file3.tsline (1 line). This restores the full 3-file program and the expected diagnostics, matching the classic baselines exactly.Baselines: new
augmentExportEquals2.errors.txt+ updated.js/.types/.symbols.Credit to Anders Hejlsberg (@ahejlsberg) for diagnosing this on 2026-04-21: "the test is broken. There are two
// @filename: file3.tsin a row, which we apparently no longer handle."Scope note: this addresses only the
augmentExportEquals2half of #63814. TheexportAssignmentMembersVisibleInAugmentationspurious TS4060 regression and the@types/nodePlatformPathaugmentation failure remain open — both require deeper checker work.Verified locally: full
hereby test(no new failures),hereby lint,hereby format,hereby check:format,hereby generate(no diff).