Repository navigation
Use ensureModifierFlags to calculate jsdoc constructor property modifiers - #64696
Merged
Wesley Wigham (weswigham) merged 1 commit intoOct 12, 2026
Conversation
Wesley Wigham (weswigham)
requested review from
Gabriela Araujo Britto (gabritto) and
Jake Bailey (jakebailey)
and
a balanced review from Copilot
October 8, 2026 17:46
typescript-automation
Bot
added
Author: Team
For Milestone Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted fix is consistent with declaration modifier handling and has focused regression coverage.
0 open findings
What changed in this PR
Fixes JSDoc visibility and readonly modifiers for JavaScript properties inferred from this assignments.
Changes:
- Derives declaration modifiers via
ensureModifierFlags. - Preserves static modifiers.
- Adds regression coverage and updates affected baselines.
| File | Description |
|---|---|
tsc/internal/transformers/declarations/transform.go |
Preserves JSDoc modifiers during declaration emit. |
tsc/testdata/tests/cases/compiler/jsDeclarationEmitThisPropertyJSDocModifiers.ts |
Tests instance and static properties. |
tsc/testdata/baselines/reference/compiler/jsDeclarationEmitThisPropertyJSDocModifiers.js |
Records expected declarations. |
tsc/testdata/baselines/reference/conformance/jsdocReadonlyDeclarations.js |
Updates readonly output. |
tsc/testdata/baselines/reference/conformance/jsdocAccessibilityTagsDeclarations.js |
Updates accessibility output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Curious question: will this PR affect microsoft/typescript-go#3665 too? Since it is previously closed as wont-fix, I suppose the example code there is not included in ts repo's test cases, hence the CI check may have missed something. 🤔 |
Member
|
I would assume none? You're asking for the old override behavior back, but this just fixes an emit bug? |
Jake Bailey (jakebailey)
approved these changes
Oct 9, 2026
Wesley Wigham (weswigham)
deleted the
jsdoc-constructor-jsdoc-modifiers
branch
October 12, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64628