Make computed property names always checked, regardless of parent grammar errors by weswigham · Pull Request #64674 · microsoft/TypeScript

Wesley Wigham (weswigham) · 2026-10-07T17:39:43Z

Fixes a source of flaky diags that can be hidden from .d.ts authors with overliberal use of skipLibCheck.

Wesley Wigham (weswigham) · 2026-10-07T17:41:51Z

In theory this could fix most of the flakes reported in insiders telemetry, but in practice I doubt it does - this flakiness could mask basically any diagnostic code, since we were just skipping a subtree entirely (which then gets checked when emit asks questions about it to do its' best, anyway). We'll have to see what we start getting in after this.

Copilot

🟡 Changes recommended

The alias-retention behavior changed in the checker lacks a regression test using an imported value.

1 open finding

Add multi-file test for enum alias import retention · New

What changed in this PR

Ensures expressions in invalid enum computed property names are still semantically checked, preventing diagnostics from depending on declaration-checking order.

Changes:

Checks enum computed-name expressions.
Enables alias reference tracking within those expressions.
Adds regression tests and updates diagnostic baselines.

File	Description
`tsc/internal/checker/checker.go`	Checks computed enum names and tracks aliases.
`tsc/testdata/tests/cases/compiler/flakyDiagnostic6385.ts`	Tests deprecation suggestions.
`tsc/testdata/tests/cases/compiler/flakyDiagnostic6133SkippedExpression.ts`	Tests unused-local tracking.
`tsc/testdata/tests/cases/compiler/flakyDiagnostic2695.ts`	Tests comma-expression diagnostics.
`tsc/testdata/tests/cases/compiler/flakyDiagnostic2552.ts`	Tests spelling suggestions.
`tsc/testdata/tests/cases/compiler/flakyDiagnostic2356.ts`	Tests invalid arithmetic diagnostics.
`tsc/testdata/tests/cases/compiler/flakyDiagnostic2322EnumComputedName.ts`	Tests nested assignment diagnostics.
`tsc/testdata/tests/cases/compiler/flakyDiagnostic2307.ts`	Tests unresolved-module diagnostics.
`tsc/testdata/tests/cases/compiler/flakyDiagnostic2304.ts`	Tests unresolved-name diagnostics.
`tsc/testdata/tests/cases/compiler/flakyDiagnostic1038.ts`	Tests nested grammar diagnostics.
`tsc/testdata/baselines/reference/conformance/parserES5ComputedPropertyName6(target=es2015).errors.txt`	Updates expected diagnostics.
`tsc/testdata/baselines/reference/conformance/parserComputedPropertyName34.errors.txt`	Updates expected diagnostics.
`tsc/testdata/baselines/reference/conformance/parserComputedPropertyName30.errors.txt`	Updates expected diagnostics.
`tsc/testdata/baselines/reference/conformance/parserComputedPropertyName26.errors.txt`	Updates expected diagnostics.
`tsc/testdata/baselines/reference/conformance/parserComputedPropertyName16.errors.txt`	Updates expected diagnostics.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic6385.types`	Records inferred types.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic6385.symbols`	Records resolved symbols.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic6385.js`	Records emitted output.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic6385.errors.txt`	Records expected diagnostics.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic6133SkippedExpression.types`	Records inferred types.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic6133SkippedExpression.symbols`	Records resolved symbols.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic6133SkippedExpression.js`	Records emitted output.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic6133SkippedExpression.errors.txt`	Records expected diagnostics.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2695.types`	Records inferred types.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2695.symbols`	Records resolved symbols.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2695.js`	Records emitted output.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2695.errors.txt`	Records expected diagnostics.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2552.types`	Records inferred types.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2552.symbols`	Records resolved symbols.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2552.js`	Records emitted output.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2552.errors.txt`	Records expected diagnostics.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2356.types`	Records inferred types.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2356.symbols`	Records resolved symbols.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2356.js`	Records emitted output.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2356.errors.txt`	Records expected diagnostics.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2322EnumComputedName.types`	Records inferred types.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2322EnumComputedName.symbols`	Records resolved symbols.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2322EnumComputedName.js`	Records emitted output.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2322EnumComputedName.errors.txt`	Records expected diagnostics.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2307.types`	Records inferred types.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2307.symbols`	Records resolved symbols.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2307.js`	Records emitted output.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2307.errors.txt`	Records expected diagnostics.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2304.types`	Records inferred types.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2304.symbols`	Records resolved symbols.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2304.js`	Records emitted output.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic2304.errors.txt`	Records expected diagnostics.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic1038.types`	Records inferred types.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic1038.symbols`	Records resolved symbols.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic1038.js`	Records emitted output.
`tsc/testdata/baselines/reference/compiler/flakyDiagnostic1038.errors.txt`	Records expected diagnostics.

🧠 Review effort: Balanced

 			if computedName != nil {
-				if ast.IsEnumMember(computedName.Parent) {
-					return
-				}
 				if isInvalidComputedPropertyName(computedName) {
 					return


Daniel Rosenwasser (DanielRosenwasser)

I don't really like the naming flakyDiagnostic... - though it is fine to comment that that's the reason @declaration is being specified in the test case.

Jake Bailey (jakebailey)

LGTM, but can reapprove if the test names are changing

Jake Bailey (jakebailey) · 2026-10-07T22:22:26Z

TypeScript Bot (@typescript-bot) test it

typescript-automation · 2026-10-07T22:22:33Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-automation · 2026-10-07T22:49:09Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-automation · 2026-10-07T22:51:53Z

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing baseline and pr:

Everything looks good!

typescript-automation · 2026-10-07T22:52:31Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - native}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_115,276	_115,276	_~	_~	_~	_{p=1.000 n=12}
_Types	_79,613	_79,613	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{139,439k (± 0.07%)}	_{139,418k (± 0.05%)}	_~	_139,288k	_139,665k	_{p=0.755 n=12}
_{Memory Allocs}	_{2,190,665 (± 0.01%)}	_{2,190,688 (± 0.01%)}	_~	_2,190,405	_2,191,011	_{p=0.671 n=12}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.040s (± 3.28%)}	_{0.041s (± 2.75%)}	_~	_0.039s	_0.044s	_{p=0.447 n=12}
_{Bind Time}	_{0.013s (±11.66%)}	_{0.012s (±10.18%)}	_~	_0.010s	_0.016s	_{p=0.966 n=12}
_{Check Time}	_{0.497s (± 0.77%)}	_{0.505s (± 0.59%)}	_{+0.008s (+ 1.57%)}	_0.497s	_0.513s	_{p=0.003 n=12}
_{Emit Time}	_{0.274s (± 2.20%)}	_{0.277s (± 2.41%)}	_~	_0.266s	_0.299s	_{p=0.744 n=12}
_{Total Time}	_{0.832s (± 0.86%)}	_{0.843s (± 0.77%)}	_{+0.011s (+ 1.29%)}	_0.827s	_0.858s	_{p=0.027 n=12}
_{angular-1 - native}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_{845,540 (± 0.07%)}	_{845,715 (± 0.06%)}	_~	_844,246	_846,767	_{p=0.843 n=12}
_Types	_{248,125 (± 0.00%)}	_{248,124 (± 0.00%)}	_~	_248,122	_248,125	_{p=0.065 n=12}
_{Memory Used}	_{784,279k (± 0.02%)}	_{784,327k (± 0.02%)}	_~	_783,909k	_784,703k	_{p=0.788 n=12}
_{Memory Allocs}	_{12,839,061 (± 0.01%)}	_{12,840,604 (± 0.01%)}	_~	_12,837,522	_12,846,017	_{p=0.198 n=12}
_{Config Time}	_{0.016s (± 1.90%)}	_{0.017s (± 1.99%)}	_~	_0.016s	_0.017s	_{p=0.680 n=12}
_{Parse Time}	_{0.260s (± 2.06%)}	_{0.259s (± 2.41%)}	_~	_0.241s	_0.271s	_{p=0.854 n=12}
_{Bind Time}	_{0.059s (± 0.64%)}	_{0.062s (± 6.50%)}	_~	_0.058s	_0.080s	_{p=0.293 n=12}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=12}
_{Emit Time}	_{1.590s (± 0.73%)}	_{1.591s (± 0.81%)}	_~	_1.566s	_1.640s	_{p=0.977 n=12}
_{Total Time}	_{1.936s (± 0.66%)}	_{1.939s (± 0.64%)}	_~	_1.910s	_1.975s	_{p=0.619 n=12}
_{mui-docs - native}
_Errors	_11,405	_11,405	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_4,359,614	_4,359,614	_~	_~	_~	_{p=1.000 n=12}
_Types	_1,376,379	_1,376,379	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{2,955,992k (± 0.06%)}	_{2,955,102k (± 0.04%)}	_~	_2,951,977k	_2,958,209k	_{p=0.630 n=12}
_{Memory Allocs}	_{32,859,790 (± 0.04%)}	_{32,834,756 (± 0.06%)}	_~	_32,773,067	_32,876,789	_{p=0.052 n=12}
_{Config Time}	_{0.017s (± 1.07%)}	_{0.017s (± 1.99%)}	_~	_0.016s	_0.017s	_{p=0.069 n=12}
_{Parse Time}	_{0.495s (± 3.40%)}	_{0.491s (± 3.63%)}	_~	_0.429s	_0.520s	_{p=0.843 n=12}
_{Bind Time}	_0.002s	_0.002s	_~	_~	_~	_{p=1.000 n=12}
_{Check Time}	_{8.571s (± 0.37%)}	_{8.617s (± 0.52%)}	_~	_8.524s	_8.724s	_{p=0.164 n=12}
_{Emit Time}	_{0.553s (±14.64%)}	_{0.499s (±14.77%)}	_~	_0.416s	_0.682s	_{p=0.830 n=12}
_{Total Time}	_{10.404s (± 0.61%)}	_{10.390s (± 0.60%)}	_~	_10.243s	_10.529s	_{p=0.745 n=12}
_{strada-build-src - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_1,390,229	_1,390,229	_~	_~	_~	_{p=1.000 n=12}
_Types	_441,498	_441,498	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{1,686,651k (± 1.01%)}	_{1,678,356k (± 0.94%)}	_~	_1,650,438k	_1,716,582k	_{p=0.319 n=12}
_{Memory Allocs}	_{92,226,704 (± 0.09%)}	_{92,176,064 (± 0.14%)}	_~	_91,796,122	_92,407,374	_{p=0.713 n=12}
_{Config Time}	_{0.003s (±14.59%)}	_{0.003s (±14.59%)}	_~	_0.002s	_0.004s	_{p=1.000 n=12}
_{Parse Time}	_{0.203s (± 3.74%)}	_{0.196s (± 4.40%)}	_~	_0.182s	_0.226s	_{p=0.192 n=12}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Check Time}	_{1.817s (± 0.46%)}	_{1.828s (± 0.63%)}	_~	_1.807s	_1.867s	_{p=0.235 n=12}
_{Emit Time}	_{0.287s (± 5.27%)}	_{0.295s (± 5.05%)}	_~	_0.243s	_0.324s	_{p=0.418 n=12}
_{Total Time}	_{23.523s (± 0.68%)}	_{23.649s (± 0.79%)}	_~	_23.120s	_24.055s	_{p=0.242 n=12}
_{strada-compiler - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_334,953	_334,953	_~	_~	_~	_{p=1.000 n=12}
_Types	_197,616	_197,616	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{313,231k (± 0.02%)}	_{313,206k (± 0.04%)}	_~	_312,936k	_313,521k	_{p=0.799 n=12}
_{Memory Allocs}	_{4,623,734 (± 0.01%)}	_{4,623,217 (± 0.01%)}	_{-517 (- 0.01%)}	_4,622,372	_4,624,442	_{p=0.039 n=12}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.117s (± 5.36%)}	_{0.112s (± 3.06%)}	_~	_0.104s	_0.122s	_{p=0.247 n=12}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Check Time}	_{1.053s (± 0.37%)}	_{1.059s (± 0.39%)}	_{+0.006s (+ 0.56%)}	_1.048s	_1.072s	_{p=0.039 n=12}
_{Emit Time}	_{0.131s (±11.01%)}	_{0.123s (±12.65%)}	_~	_0.095s	_0.153s	_{p=0.400 n=12}
_{Total Time}	_{1.352s (± 0.79%)}	_{1.349s (± 0.97%)}	_~	_1.324s	_1.388s	_{p=0.541 n=12}
_{ts-pre-modules - native}
_Errors	₈₇	₈₇	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_303,834	_303,834	_~	_~	_~	_{p=1.000 n=12}
_Types	_181,663	_181,663	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{273,897k (± 0.02%)}	_{273,931k (± 0.02%)}	_~	_273,816k	_274,123k	_{p=0.418 n=12}
_{Memory Allocs}	_{1,616,111 (± 0.01%)}	_{1,615,959 (± 0.02%)}	_~	_1,615,393	_1,616,532	_{p=0.378 n=12}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.096s (± 3.27%)}	_{0.099s (± 4.22%)}	_~	_0.087s	_0.110s	_{p=0.296 n=12}
_{Bind Time}	_{0.039s (±10.82%)}	_{0.038s (±10.37%)}	_~	_0.030s	_0.048s	_{p=0.619 n=12}
_{Check Time}	_{0.822s (± 0.38%)}	_{0.831s (± 0.54%)}	_{+0.009s (+ 1.07%)}	_0.821s	_0.841s	_{p=0.002 n=12}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Total Time}	_{0.972s (± 0.80%)}	_{0.983s (± 0.87%)}	_~	_0.967s	_1.007s	_{p=0.057 n=12}
_{vscode - native}
_Errors	₃₈₀	₃₈₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_10,938,788	_10,938,788	_~	_~	_~	_{p=1.000 n=12}
_Types	_3,629,325	_3,629,325	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{7,038,564k (± 0.02%)}	_{7,039,654k (± 0.02%)}	_~	_7,035,529k	_7,043,456k	_{p=0.291 n=12}
_{Memory Allocs}	_{54,035,557 (± 0.02%)}	_{54,041,214 (± 0.03%)}	_~	_54,023,328	_54,120,284	_{p=0.443 n=12}
_{Config Time}	_{0.073s (± 0.52%)}	_{0.073s (± 0.42%)}	_~	_0.073s	_0.074s	_{p=0.278 n=12}
_{Parse Time}	_{1.827s (± 3.10%)}	_{1.830s (± 3.15%)}	_~	_1.682s	_1.949s	_{p=0.932 n=12}
_{Bind Time}	_{0.555s (±20.82%)}	_{0.528s (±14.43%)}	_~	_0.446s	_0.787s	_{p=0.765 n=12}
_{Check Time}	_{14.231s (± 1.21%)}	_{14.189s (± 1.10%)}	_~	_13.820s	_14.472s	_{p=0.810 n=12}
_{Emit Time}	_{5.077s (± 9.43%)}	_{5.191s (±10.35%)}	_~	_4.129s	_6.226s	_{p=0.601 n=12}
_{Total Time}	_{21.844s (± 1.81%)}	_{21.897s (± 1.87%)}	_~	_21.073s	_22.646s	_{p=0.671 n=12}
_{webpack - native}
_Errors	₅₈₉	₅₈₉	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_1,290,065	_1,290,065	_~	_~	_~	_{p=1.000 n=12}
_Types	_601,747	_601,747	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{995,597k (± 0.02%)}	_{995,634k (± 0.02%)}	_~	_994,763k	_996,118k	_{p=0.590 n=12}
_{Memory Allocs}	_{6,461,739 (± 0.02%)}	_{6,461,371 (± 0.02%)}	_~	_6,457,893	_6,464,962	_{p=0.843 n=12}
_{Config Time}	_0.009s	_0.009s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.279s (± 2.47%)}	_{0.286s (± 2.91%)}	_~	_0.261s	_0.306s	_{p=0.192 n=12}
_{Bind Time}	_{0.090s (±15.63%)}	_{0.078s (±18.12%)}	_~	_0.063s	_0.121s	_{p=0.310 n=12}
_{Check Time}	_{1.964s (± 0.54%)}	_{1.959s (± 0.49%)}	_~	_1.938s	_1.993s	_{p=0.340 n=12}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Total Time}	_{2.378s (± 0.77%)}	_{2.367s (± 0.84%)}	_~	_2.335s	_2.430s	_{p=0.355 n=12}
_{xstate-main - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_1,055,452	_1,055,452	_~	_~	_~	_{p=1.000 n=12}
_Types	_386,738	_386,738	_~	_~	_~	_{p=1.000 n=12}
_{Memory Used}	_{613,159k (± 0.02%)}	_{613,234k (± 0.02%)}	_~	_612,880k	_613,479k	_{p=0.319 n=12}
_{Memory Allocs}	_{4,862,087 (± 0.10%)}	_{4,862,777 (± 0.11%)}	_~	_4,846,537	_4,871,446	_{p=0.799 n=12}
_{Config Time}	_0.003s	_{0.003s (± 6.23%)}	_~	_0.002s	_0.003s	_{p=1.000 n=12}
_{Parse Time}	_{0.144s (± 3.83%)}	_{0.143s (± 3.79%)}	_~	_0.128s	_0.155s	_{p=0.831 n=12}
_{Bind Time}	_{0.043s (±17.99%)}	_{0.042s (±18.10%)}	_~	_0.032s	_0.068s	_{p=0.722 n=12}
_{Check Time}	_{1.147s (± 0.70%)}	_{1.149s (± 0.84%)}	_~	_1.129s	_1.182s	_{p=0.943 n=12}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Total Time}	_{1.346s (± 0.91%)}	_{1.344s (± 0.77%)}	_~	_1.319s	_1.372s	_{p=0.787 n=12}

System info unknown

Hosts

native

Scenarios

Compiler-Unions - native
angular-1 - native
mui-docs - native
strada-build-src - native
strada-compiler - native
ts-pre-modules - native
vscode - native
webpack - native
xstate-main - native

_Benchmark	_Name	_Iterations
_Current	_pr	₁₂
_Baseline	_baseline	₁₂

Developer Information:

Download Benchmarks

typescript-automation · 2026-10-07T23:43:28Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing baseline and pr:

Everything looks good!

Wesley Wigham (weswigham) added 2 commits October 6, 2026 16:26

Add repros for a bunch of flaky diagnostics

86d889e

Always check computed names, regardless of parent grammar errors

a8f8702

Wesley Wigham (weswigham) requested review from Daniel Rosenwasser (DanielRosenwasser) and Jake Bailey (jakebailey) and a balanced review from Copilot October 7, 2026 17:39

github-project-automation Bot added this to PR Backlog Oct 7, 2026

typescript-automation Bot assigned Wesley Wigham (weswigham) Oct 7, 2026

typescript-automation Bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 7, 2026

Copilot started reviewing on behalf of Wesley Wigham (weswigham) October 7, 2026 17:40

View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread tsc/internal/checker/checker.go

Comment on lines 28793 to 28795

if computedName != nil {

if ast.IsEnumMember(computedName.Parent) {

return

}

if isInvalidComputedPropertyName(computedName) {

return

Daniel Rosenwasser (DanielRosenwasser) requested changes Oct 7, 2026

View reviewed changes

Jake Bailey (jakebailey) approved these changes Oct 7, 2026

View reviewed changes

Wesley Wigham (weswigham) added 3 commits October 7, 2026 14:57

Merge branch 'main' into diag-investigations

94dd63b

Rename tests

c433f63

Add the extra test the automated review asked for, why not

672b025

Wesley Wigham (weswigham) requested review from Daniel Rosenwasser (DanielRosenwasser) and Jake Bailey (jakebailey) October 7, 2026 22:20

Wesley Wigham (weswigham) enabled auto-merge October 7, 2026 22:21

Daniel Rosenwasser (DanielRosenwasser) approved these changes Oct 7, 2026

View reviewed changes

Wesley Wigham (weswigham) added this pull request to the merge queue Oct 7, 2026

Merged via the queue into microsoft:main with commit ec47d33 Oct 7, 2026
29 checks passed

Wesley Wigham (weswigham) deleted the diag-investigations branch October 7, 2026 23:22

Boshen (Boshen) mentioned this pull request Oct 19, 2026

Port upstream TypeScript oxc-project/tsrs#623

Closed

Navigation Menu

Repository navigation

Make computed property names always checked, regardless of parent grammar errors - #64674

Make computed property names always checked, regardless of parent grammar errors#64674
Wesley Wigham (weswigham) merged 5 commits into
microsoft:mainfrom
weswigham:diag-investigations

Wesley Wigham (weswigham) commented Oct 7, 2026

Uh oh!

Wesley Wigham (weswigham) commented Oct 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) left a comment

Uh oh!

Jake Bailey (jakebailey) left a comment

Uh oh!

Jake Bailey (jakebailey) commented Oct 7, 2026

Uh oh!

typescript-automation Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

typescript-automation Bot commented Oct 7, 2026

Uh oh!

typescript-automation Bot commented Oct 7, 2026

Uh oh!

typescript-automation Bot commented Oct 7, 2026

tsc

Uh oh!

Uh oh!

typescript-automation Bot commented Oct 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Wesley Wigham (weswigham) commented Oct 7, 2026

Uh oh!

Wesley Wigham (weswigham) commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) left a comment

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) commented Oct 7, 2026

Uh oh!

typescript-automation Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-automation Bot commented Oct 7, 2026

Uh oh!

typescript-automation Bot commented Oct 7, 2026

Uh oh!

typescript-automation Bot commented Oct 7, 2026

tsc

Uh oh!

Uh oh!

typescript-automation Bot commented Oct 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Wesley Wigham (weswigham) commented Oct 7, 2026 •

edited

Loading

typescript-automation Bot commented Oct 7, 2026 •

edited

Loading