Repository navigation
Add explicit collection selection and node labels to testsuite - #215
Merged
Matthew Parkinson (mjp41) merged 2 commits intoOct 2, 2026
Merged
Matthew Parkinson (mjp41) merged 2 commits into
Matthew Parkinson (mjp41) merged 2 commits into
Conversation
This was referenced Sep 28, 2026
Qianhui Wang (qhuiw)
force-pushed
the
feature/testsuite-collections-labels
branch
from
September 28, 2026 09:20
bc6470c to
d574854
Compare
Contributor
Author
|
Rebased onto current
The Verona VBC and full architecture consumers have both been repinned to this head. |
Contributor
Author
|
Verona compatibility fix opened upstream: sylvanc/verona-bc#100. That PR corrects the existing |
- Add a `COLLECTIONS` argument to assign collection ownership explicitly when suites share one fixture tree. - Preserve adjacent-file discovery when callers omit the new argument. - Reject missing, duplicate, directory, traversal, and otherwise unsafe collection paths at configure time. - Add focused compatibility and validation scenarios for explicit and implicit registration. - Document collection selection and validate the change with the full 30-test Trieste suite.
- Add optional `LABELS` metadata to named testsuite nodes. - Keep the suite name as an automatic CTest label and append caller-provided labels. - Deduplicate repeated labels without changing node registration or dependency semantics. - Add a focused configuration scenario covering suite and node label composition. - Document label filtering and validate the change with the full 31-test Trieste suite.
Matthew Parkinson (mjp41)
force-pushed
the
feature/testsuite-collections-labels
branch
from
October 2, 2026 09:36
d574854 to
bf0c3ea
Compare
Matthew Parkinson (mjp41)
enabled auto-merge (squash)
October 2, 2026 10:06
Matthew Parkinson (mjp41)
merged commit Oct 2, 2026
70a79da
into
microsoft:main
28 of 29 checks passed
Qianhui Wang (qhuiw)
added a commit
to qhuiw/verona-bc
that referenced
this pull request
Oct 2, 2026
Use the upstream squash commit for microsoft/Trieste#215 now that the temporary fork commit is no longer reachable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Qianhui Wang (qhuiw)
added a commit
to qhuiw/verona-bc
that referenced
this pull request
Oct 2, 2026
Pin the merged microsoft/Trieste#215 commit containing explicit collection selection and node-label support. Keep Verona testsuite registration behavior unchanged in this dependency-only step. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COLLECTIONStotestsuite()for explicit collection ownership.LABELSmetadata totestsuite_add_test().Rationale
Consumers may define multiple logical suites over one shared fixture tree. Implicitly loading every adjacent collection causes duplicate registration and makes suite ownership ambiguous.
Additional node labels allow consumers to expose orthogonal CTest views, such as frontend and backend, without using labels to configure registration.
Compatibility
Existing
testsuite(name)calls continue discovering adjacent collections whenCOLLECTIONSis omitted. Existing nodes retain the automatic suite label when additional labels are not provided.Consumers
Validation