[DICOM] Remove Int64 overflow path in length-matched crypto hash output - #266
Draft
Josiah Vinson (jovinson-ms) with Copilot wants to merge 4 commits into
Draft
[DICOM] Remove Int64 overflow path in length-matched crypto hash output#266Josiah Vinson (jovinson-ms) with Copilot wants to merge 4 commits into
Josiah Vinson (jovinson-ms) with Copilot wants to merge 4 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jovinson-ms <88204686+jovinson-ms@users.noreply.github.com>
Co-authored-by: jovinson-ms <88204686+jovinson-ms@users.noreply.github.com>
Co-authored-by: jovinson-ms <88204686+jovinson-ms@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix overflow exception in crypto hash output length
[DICOM] Remove Int64 overflow path in length-matched crypto hash output
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MatchInputStringLength=truecould throwOverflowExceptionfor numeric inputs with 19+ digits because the length-preserving path depended onInt64bounds. This change removes that failure mode while keeping deterministic, numeric-only, exact-length output behavior.Length-preserving hash generation
GenerateOutputOfSameLengthto avoidInt64-bounded range construction for long inputs.<=18digits) where practical.BigInteger-based mapping for longer lengths (>18) to preserve fixed-length numeric output without overflow.Deterministic long-length expansion
Boundary coverage for regression