Skip to content

Feature/GitHub codespaces organization - #416

Open
Jason Vercellone (vercellone) wants to merge 97 commits into
microsoft:masterfrom
vercellone:feature/GitHubCodespaces-organization
Open

Feature/GitHub codespaces organization#416
Jason Vercellone (vercellone) wants to merge 97 commits into
microsoft:masterfrom
vercellone:feature/GitHubCodespaces-organization

Conversation

@vercellone

@vercellone Jason Vercellone (vercellone) commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

Description

Add outstanding support for Codespaces organizations and Codespaces machines.

Issues Fixed

References

Codespaces/organizations

Codespaces/machines

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Formatters were created for any new types being added.
  • New/changed code continues to support the pipeline.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
not howard

Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
@vercellone

Copy link
Copy Markdown
Contributor Author

Please review, Howard Wolosky (@HowardWolosky).

@vercellone

Copy link
Copy Markdown
Contributor Author

TypeName assertions resolved. Any other feedback, Howard Wolosky (@HowardWolosky)?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those updates. Looks just about there. I'll kick off a validation run to see if I missed anything else.

Comment thread GitHubCodespaces.ps1
Comment thread GitHubCodespaces.ps1
GitHub Apps must have write access to the codespaces_lifecycle_admin repository permission to use this endpoint.
#>
[CmdletBinding(
DefaultParameterSetName = 'AuthenticatedUser',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference here would be to avoid ambiguous code. As a code reader, it took too much time for me to look at what's here and parse out what might be happening. A comment could probably address that, but even better would simply be having the code be declarative on intention. In this specific scenario, this could be resolved by augmenting the $CodespaceName declaration to be part of two different parametersets, and then having the default one be one that's actually defined.

        [Parameter(
            Mandatory,
            ValueFromPipeline,
            ValueFromPipelineByPropertyName,
            ParameterSetName = 'Organization')]
        [Parameter(
            Mandatory,
            ValueFromPipeline,
            ValueFromPipelineByPropertyName,
            ParameterSetName = 'AuthenticatedUser')]
        [string] $CodespaceName,

Comment thread GitHubCodespaces.ps1 Outdated
Comment thread GitHubCodespaces.ps1 Outdated
Comment thread GitHubCodespaces.ps1 Outdated
Comment thread GitHubCodespaces.ps1 Outdated
Comment thread GitHubCodespaces.ps1 Outdated
Comment thread GitHubCodespaces.ps1
Comment thread GitHubCodespaces.ps1 Outdated
Comment thread GitHubCodespaces.ps1 Outdated
@HowardWolosky

Copy link
Copy Markdown
Contributor

/azp run PowerShellForGitHub-CI

Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
$null = Invoke-GHRestMethod @params

Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
@vercellone

Copy link
Copy Markdown
Contributor Author

Please review again, Howard Wolosky (@HowardWolosky).

@vercellone

Copy link
Copy Markdown
Contributor Author

Howard Wolosky (@HowardWolosky) 8 months!? Your resource management policy seems a bit biased.

@vercellone

Copy link
Copy Markdown
Contributor Author

@vercellone

Copy link
Copy Markdown
Contributor Author

Am I missing something here? How can I move this PR forward? Should I submit a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants