Skip to content

Fix MDA test plan code injection - #687

Closed
Brad Flood (brflood) wants to merge 2 commits into
mainfrom
users/brflood/IcM864471946
Closed

Fix MDA test plan code injection#687
Brad Flood (brflood) wants to merge 2 commits into
mainfrom
users/brflood/IcM864471946

Conversation

@brflood

@brflood Brad Flood (brflood) commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove eval-based custom page wrappers that allowed plan-controlled property names to become JavaScript source
  • pass MDA SetProperty item paths and values through Playwright structured arguments
  • preserve date behavior and JavaScript object identity for empty and non-empty records
  • execute custom-page SetProperty tests against the real helper path
  • cover records, tables, dates, GUIDs, hostile strings, and nested gallery item paths at the Playwright serialization boundary

Validation

  • MDA provider tests: 124 passed, 3 skipped
  • Playwright infrastructure tests: 49 passed

Remove eval-based custom page wrappers and pass SetProperty inputs to Playwright as structured arguments so plan-controlled names and values cannot become executable JavaScript.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@brflood
Brad Flood (brflood) requested a review from a team as a code owner September 8, 2026 19:07
Serialize records with ExpandoObject so empty records remain JavaScript objects, and expand custom-page and Playwright serialization coverage across structured values and nested item paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant