chore: Add Popup for timeout#1016
Open
Ragini-Microsoft wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds robust handling for session timeouts in the frontend application. The main change is the introduction of a non-dismissible session timeout dialog that appears when the backend notifies the frontend of a session timeout via a new websocket message type. This ensures users receive clear feedback and are guided to return to the home page if their session expires.
Session Timeout Handling:
SessionTimeoutDialogcomponent to display a session timeout message and guide users back to the home page. (src/frontend/src/components/common/SessionTimeoutDialog.tsx)SessionTimeoutDialogintoPlanPage, including state management to show/hide the dialog and navigation logic to redirect users home when the dialog is acknowledged. (src/frontend/src/pages/PlanPage.tsx) [1] [2] [3]Websocket Integration:
TIMEOUT_NOTIFICATION, to theWebsocketMessageTypeenum. (src/frontend/src/models/enums.tsx)WebSocketServiceto handle the newTIMEOUT_NOTIFICATIONmessage type and emit the appropriate event. (src/frontend/src/services/WebSocketService.tsx)PlanPageto listen for theTIMEOUT_NOTIFICATIONwebsocket event, display the session timeout dialog, and disconnect the websocket. (src/frontend/src/pages/PlanPage.tsx)Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information