Skip to content

fix(desktop): auto-open DevTools only for UI dev, not every unpacked run #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yuqing (mydmdm) merged 1 commit into from
Sep 5, 2026
+9 −1
Merged

fix(desktop): auto-open DevTools only for UI dev, not every unpacked run #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion apps/desktop/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@
// non-zero exit we dump the captured stderr ring as a crash file.

serverExitPromise = new Promise((resolve) => {
serverProcess!.on('exit', (code) => {

Check warning on line 616 in apps/desktop/src/main.ts

View workflow job for this annotation

GitHub Actions / Lint / Format / Typecheck / Test / Build 

Forbidden non-null assertion
if (code !== 0) {
console.error(`[desktop] server exited with code ${code}`);
dumpServerCrash(code ?? -1);
Expand Down Expand Up @@ -1086,7 +1086,15 @@
}
});

if (IS_DEV) {
// Auto-open DevTools only for real UI development (Vite HMR via
// dev:desktop) or when explicitly requested with HUABU_DEVTOOLS=1.
// Other unpacked runs (e.g. `start:desktop`, or an unpacked production
// build run straight from source) behave like production. F12 /
// Ctrl+Shift+I still toggle them at any time (see above).
if (
IS_DEV &&
(process.env.WEB_DEV_SERVER_URL || process.env.HUABU_DEVTOOLS === '1')
) {
mainWindow.webContents.openDevTools();
}

Expand Down
Loading