Fix Windows multiline test yamls#1686
Open
zanejohnson-azure wants to merge 1 commit into
Open
Conversation
- Bump powershell base image from lts-nanoserver-1809 to lts-nanoserver-ltsc2022 to match the Windows nodepool OS on AKS test clusters (1809 nodes are no longer common). - Drop hard-coded kubernetes.io/os and kubernetes.io/arch nodeSelector; AKS already places Windows pods correctly via image OS metadata, and the explicit selector blocks scheduling on clusters whose node labels differ. Verified by deploying these jobs to zane-ama-logs-helm-test (ltsc2022 nodepool) and confirming logs flow through ContainerLogV2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| - name: java-win-scripts-volume | ||
| configMap: | ||
| name: java-win-test-scripts | ||
| nodeSelector: |
Contributor
There was a problem hiding this comment.
i thought all aks windows nodes had these labels. is that not right?
Contributor
Author
There was a problem hiding this comment.
this nodeSelector appeared twice in the yaml, remove one of the two @rashmichandrashekar
nodeSelector:
kubernetes.io/os: windows
kubernetes.io/arch: amd64
volumes:
- name: dotnet-win-scripts-volume
configMap:
name: dotnet-win-test-scripts
nodeSelector:
kubernetes.io/os: windows
kubernetes.io/arch: amd64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified by deploying these jobs to zane-ama-logs-helm-test (ltsc2022 nodepool) and confirming logs flow through ContainerLogV2.