Exclude azuresecuritylinuxagent namespace from log collection by default#1680
Open
zanejohnson-azure wants to merge 1 commit into
Open
Exclude azuresecuritylinuxagent namespace from log collection by default#1680zanejohnson-azure wants to merge 1 commit into
zanejohnson-azure wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| exclude_namespaces = ["kube-system","gatekeeper-system"] | ||
| # kube-system,gatekeeper-system,azuresecuritylinuxagent log collection are disabled by default in the absence of 'log_collection_settings.stderr' setting. If you want to enable kube-system,gatekeeper-system,azuresecuritylinuxagent, remove them from the following setting. | ||
| # If you want to continue to disable kube-system,gatekeeper-system,azuresecuritylinuxagent log collection keep the namespaces in the following setting and add any other namespace you want to disable log collection to the array. | ||
| # In the absense of this configmap, default value for exclude_namespaces = ["kube-system","gatekeeper-system","azuresecuritylinuxagent"] |
Contributor
There was a problem hiding this comment.
thanks @zanejohnson-azure . shoudl we also add a test to ensure data from this namespace is excluded?
Contributor
Author
There was a problem hiding this comment.
tested on a cluster.
see below. when new image is deployed around 4:56 AM, we see logs from azure linux security agent is NOT collected anymore.
i also checked logs from other namespace, and confirm they are not affected by this change.
Contributor
Author
There was a problem hiding this comment.
if an cx wants to collect it, they can enable through using configmap
by changing
exclude_namespaces = ["kube-system","gatekeeper-system","azuresecuritylinuxagent"]
to
exclude_namespaces = ["kube-system","gatekeeper-system"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
azuresecuritylinuxagentto the built-in default exclusion lists so logs from theazuresecuritylinuxagentnamespace (deployed by a sister team) are not collected by ama-logs out of the box.Changes
build/common/installer/scripts/tomlparser.rb@stdoutExcludeNamespacesand@stderrExcludeNamespacesdefaults now includeazuresecuritylinuxagent.@excludePathdefaults (no-configmap, parse-error, unsupported-schema-version branches) now include*_azuresecuritylinuxagent_*.log.kubernetes/container-azm-ms-agentconfig.yamlexclude_namespacesarrays and surrounding comments updated.Effect
tailinput skips opening files in this namespace viaExclude_Path(no I/O, no parsing).Caveat
The customer-supplied configmap replaces the default arrays. If a customer has an
exclude_namespacessetting in their configmap that does not includeazuresecuritylinuxagent, the namespace will still be collected. Documenting this and deciding whether to force-append is left as a follow-up.