Avoid Locust master port collisions in virtual benchmarks - #8301
Merged
Amaury Chamayou (achamayou) merged 4 commits intoSep 7, 2026
Merged
Conversation
Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com>
Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'Benchmark Virtual'
Avoid Locust master port collisions in virtual benchmarks
Sep 7, 2026
Eddy Ashton (eddyashton)
marked this pull request as ready for review
September 7, 2026 14:39
Copilot started reviewing on behalf of
Eddy Ashton (eddyashton)
September 7, 2026 14:40
View session
Amaury Chamayou (achamayou)
approved these changes
Sep 7, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, localized, and directly addresses the stated failure mode by aligning port selection and bind scope to loopback.
Pull request overview
This PR hardens the virtual benchmark Locust invocation to avoid master port collisions caused by selecting a port on loopback but then binding the master listener on all interfaces.
Changes:
- Introduces an explicit
master_host = "localhost"for Locust master binding. - Selects
master_portusing the same loopback scope and passes--master-bind-hostto ensure Locust binds only on loopback.
Custom instructions used
- None (no repository instruction files from
.github/copilot-instructions.md/.github/instructions/were explicitly loaded via tools during this review).
File summaries
| File | Description |
|---|---|
tests/infra/locust_benchmark.py |
Bind Locust master RPC listener explicitly to loopback and select the port using the same address scope to prevent interface-scope collisions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Amaury Chamayou (achamayou)
enabled auto-merge (squash)
September 7, 2026 14:47
Amaury Chamayou (achamayou)
deleted the
copilot/fix-benchmark-virtual-job-failure
branch
September 7, 2026 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark Virtual could fail when Locust selected a port available on loopback but then bound its master listener on all interfaces. Another process bound on a non-loopback interface caused Locust startup to fail.
localhost.