Skip to content

Backport #9430: [28.x] E-Document ADI import crashes with untrappable JSON error when ADI response lacks outputs.1 structure #9901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ventselartur wants to merge 1 commit into
base: releases/28.x
Choose a base branch
from
Open

Backport #9430: [28.x] E-Document ADI import crashes with untrappable JSON error when ADI response lacks outputs.1 structure #9901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions src/Apps/W1/EDocument/App/src/Helpers/EDocumentJsonHelper.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,20 @@ codeunit 6121 "EDocument Json Helper"
{
Access = Internal;

var
MalformedAdiResponseTxt: label 'ADI response is missing the expected ''%1'' property; returning an empty object.', Locked = true;
TelemetryCategoryTxt: label 'E-Document Matching Assistance', Locked = true;

internal procedure GetHeaderFields(SourceJsonObject: JsonObject): JsonObject
var
JsonToken: JsonToken;
ContentObject: JsonObject;
ContentObject, EmptyObject : JsonObject;
begin
ContentObject := GetInnerObject(SourceJsonObject);
ContentObject.Get('fields', JsonToken);
if not ContentObject.Get('fields', JsonToken) then begin
Session.LogMessage('0000UK1', StrSubstNo(MalformedAdiResponseTxt, 'fields'), Verbosity::Warning, DataClassification::SystemMetadata, TelemetryScope::All, 'Category', TelemetryCategoryTxt);
exit(EmptyObject);
end;
exit(JsonToken.AsObject());
end;

Expand All @@ -31,13 +38,22 @@ codeunit 6121 "EDocument Json Helper"
internal procedure GetInnerObject(SourceJsonObject: JsonObject): JsonObject
var
JsonToken: JsonToken;
OutputsObject, InnerObject : JsonObject;
OutputsObject, InnerObject, EmptyObject : JsonObject;
begin
SourceJsonObject.Get('outputs', JsonToken);
if not SourceJsonObject.Get('outputs', JsonToken) then begin
Session.LogMessage('0000UK2', StrSubstNo(MalformedAdiResponseTxt, 'outputs'), Verbosity::Warning, DataClassification::SystemMetadata, TelemetryScope::All, 'Category', TelemetryCategoryTxt);
exit(EmptyObject);
end;
OutputsObject := JsonToken.AsObject();
OutputsObject.Get('1', JsonToken);
if not OutputsObject.Get('1', JsonToken) then begin
Session.LogMessage('0000UK3', StrSubstNo(MalformedAdiResponseTxt, '1'), Verbosity::Warning, DataClassification::SystemMetadata, TelemetryScope::All, 'Category', TelemetryCategoryTxt);
exit(EmptyObject);
end;
InnerObject := JsonToken.AsObject();
InnerObject.Get('result', JsonToken);
if not InnerObject.Get('result', JsonToken) then begin
Session.LogMessage('0000UK4', StrSubstNo(MalformedAdiResponseTxt, 'result'), Verbosity::Warning, DataClassification::SystemMetadata, TelemetryScope::All, 'Category', TelemetryCategoryTxt);
exit(EmptyObject);
end;
exit(JsonToken.AsObject());
end;

Expand Down
Loading