Skip to content

[Master] [Repair Item] Team Member unable to copy sales quotation when lines are associated to assembly #9644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shikhverma merged 21 commits into from
Sep 15, 2026
Merged

[Master] [Repair Item] Team Member unable to copy sales quotation when lines are associated to assembly #9644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
15b3690
Initial Commit
Shikhverma Jul 21, 2026
542713a
Invoke-Miapp
Shikhverma Jul 21, 2026
e48e0c0
Chnage
Shikhverma Jul 23, 2026
4e027fa
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
Shikhverma Jul 23, 2026
9cf6b3a
Miapp
Shikhverma Jul 23, 2026
88d0490
update fix
Shikhverma Jul 31, 2026
e1c7dcc
update Permission
Shikhverma Aug 6, 2026
ed20ea1
Automation Added
Shikhverma Aug 10, 2026
022c672
update
Shikhverma Aug 11, 2026
618d64c
fix test
Shikhverma Aug 13, 2026
3336b91
update
Shikhverma Aug 18, 2026
cfd6f19
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
Shikhverma Aug 18, 2026
8c85700
update
Shikhverma Aug 18, 2026
126a6a9
update
Shikhverma Aug 27, 2026
df6a228
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
Shikhverma Aug 31, 2026
70a20c2
update
Shikhverma Aug 31, 2026
2b45c11
Updated
Shikhverma Sep 1, 2026
7199da8
update
Shikhverma Sep 8, 2026
fa57b25
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
Shikhverma Sep 8, 2026
1bb3bb7
Invoke Miapp
Shikhverma Sep 8, 2026
848d5eb
update
Shikhverma Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Layers/ES/BaseApp/Utilities/CopyDocumentMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ using System.Utilities;

codeunit 6620 "Copy Document Mgt."
{
Permissions = TableData "Cust. Ledger Entry" = rim;
Permissions = TableData "Cust. Ledger Entry" = rim,
tabledata "Assembly Header" = rim,
tabledata "Assembly Line" = rim,
tabledata "Assemble-to-Order Link" = rim;

trigger OnRun()
begin
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/IT/BaseApp/Utilities/CopyDocumentMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ using System.Utilities;
codeunit 6620 "Copy Document Mgt."
{

Permissions =
tabledata "Assembly Header" = rim,
tabledata "Assembly Line" = rim,
tabledata "Assemble-to-Order Link" = rim;

trigger OnRun()
begin
end;
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/NA/BaseApp/Utilities/CopyDocumentMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ using System.Utilities;
codeunit 6620 "Copy Document Mgt."
{

Permissions =
tabledata "Assembly Header" = rim,
tabledata "Assembly Line" = rim,
tabledata "Assemble-to-Order Link" = rim;

trigger OnRun()
begin
end;
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/NL/BaseApp/Utilities/CopyDocumentMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ using System.Utilities;
codeunit 6620 "Copy Document Mgt."
{

Permissions =
tabledata "Assembly Header" = rim,
tabledata "Assembly Line" = rim,
tabledata "Assemble-to-Order Link" = rim;

trigger OnRun()
begin
end;
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/RU/BaseApp/Utilities/CopyDocumentMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ using System.Utilities;
codeunit 6620 "Copy Document Mgt."
{

Permissions =
tabledata "Assembly Header" = rim,
tabledata "Assembly Line" = rim,
tabledata "Assemble-to-Order Link" = rim;

trigger OnRun()
begin
end;
Expand Down
6 changes: 6 additions & 0 deletions src/Layers/W1/BaseApp/Utilities/CopyDocumentMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ using System.Utilities;
codeunit 6620 "Copy Document Mgt."
{

Permissions =
tabledata "Assembly Header" = rim,
tabledata "Assembly Line" = rim,
tabledata "Assemble-to-Order Link" = rim;

trigger OnRun()
begin
end;
Expand Down Expand Up @@ -438,6 +443,7 @@ codeunit 6620 "Copy Document Mgt."
FromDocType.AsInteger(), FromDocNo, ToSalesHeader, FromDocOccurrenceNo, FromDocVersionNo, IncludeHeader, RecalculateLines, MoveNegLines);
end;


procedure CopySalesDocSalesLine(FromSalesHeader: Record "Sales Header"; var ToSalesHeader: Record "Sales Header"; var LinesNotCopied: Integer; NextLineNo: Integer)
var
AssemblyHeader: Record "Assembly Header";
Expand Down
206 changes: 206 additions & 0 deletions src/Layers/W1/Tests/SCM/SCMCopyDocumentMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ codeunit 137212 "SCM Copy Document Mgt."
LibrarySetupStorage: Codeunit "Library - Setup Storage";
LibraryRandom: Codeunit "Library - Random";
LibraryWarehouse: Codeunit "Library - Warehouse";
LibraryE2EPlanPermissions: Codeunit "Library - E2E Plan Permissions";
IsInitialized: Boolean;
MsgCorrectedInvoiceNo: Label 'have a Corrected Invoice No. Do you want to continue?';
WrongDimensionsCopiedErr: Label 'Wrong dimensions in copied document';
Expand Down Expand Up @@ -1726,6 +1727,211 @@ codeunit 137212 "SCM Copy Document Mgt."
ReturnSalesLine.TestField(Quantity, TotalQty);
end;

[Test]
[HandlerFunctions('MessageHandler')]
[Scope('OnPrem')]
procedure CopySalesQuoteWithATOAsTeamMember()
var
Item: Record Item;
AssemblyItem: Record Item;
FromSalesHeader: Record "Sales Header";
FromSalesLine: Record "Sales Line";
ToSalesHeader: Record "Sales Header";
ToSalesLine: Record "Sales Line";
AssemblyHeader: Record "Assembly Header";
LibraryLowerPermissions: Codeunit "Library - Lower Permissions";
Qty: Decimal;
begin
// [FEATURE] [Assemble-to-Order] [Copy Document] [Permissions]
// [SCENARIO] AB#630947: A user restricted to the D365 Team Member permission set can copy a sales quote whose
// line has an assemble-to-order link, and the copy reproduces the ATO link on the target line.
Initialize();

// [GIVEN] Assemble-to-order item with a resource component (resource-only BOM avoids the
// component availability engine that would read Prod. Order tables outside the fix under test)
LibraryInventory.CreateItem(Item);
Item.Validate("Replenishment System", Item."Replenishment System"::Assembly);
Item.Validate("Assembly Policy", Item."Assembly Policy"::"Assemble-to-Order");
Item.Modify(true);
LibraryAssembly.CreateAssemblyList(
AssemblyItem."Costing Method"::Standard, Item."No.", true, 0, 1, 0, LibraryRandom.RandInt(5), '', '');

// [GIVEN] Source sales quote with the ATO item; validating the item auto-creates the ATO link
Qty := LibraryRandom.RandIntInRange(2, 10);
LibrarySales.CreateSalesDocumentWithItem(
FromSalesHeader, FromSalesLine, FromSalesHeader."Document Type"::Quote, LibrarySales.CreateCustomerNo(),
Item."No.", Qty, '', WorkDate());

// [GIVEN] Empty target sales quote created while the user still has full permissions
CreateEmptySalesHeader(ToSalesHeader, ToSalesHeader."Document Type"::Quote);
Commit();

// [GIVEN] User is now restricted to the D365 Team Member plan (regression harness for AB#630947)
LibraryE2EPlanPermissions.SetTeamMemberPlan();
Comment thread
Shikhverma marked this conversation as resolved.
Comment thread
Shikhverma marked this conversation as resolved.

// [WHEN] Copy Document is executed for the source quote into the target quote
CopyDocumentMgt.SetProperties(true, false, false, false, true, false, false);
CopyDocumentMgt.CopySalesDoc("Sales Document Type From"::Quote, FromSalesHeader."No.", ToSalesHeader);

// [THEN] The copied line exists on the target quote with the same quantity and Qty. to Assemble to Order...
LibraryLowerPermissions.SetO365Full();
ToSalesLine.SetRange("Document Type", ToSalesHeader."Document Type");
ToSalesLine.SetRange("Document No.", ToSalesHeader."No.");
ToSalesLine.SetRange(Type, ToSalesLine.Type::Item);
ToSalesLine.SetRange("No.", Item."No.");
Assert.RecordCount(ToSalesLine, 1);
ToSalesLine.FindFirst();
ToSalesLine.TestField(Quantity, Qty);
ToSalesLine.TestField("Qty. to Assemble to Order", Qty);

// [THEN] ...and an Assembly Header is linked to the copied sales line
Assert.IsTrue(
ToSalesLine.AsmToOrderExists(AssemblyHeader),
'Assemble-to-Order link should exist for the copied sales line.');
end;

[Test]
[HandlerFunctions('MessageHandler')]
[Scope('OnPrem')]
procedure CopySalesQuoteWithItemComponentATOAsTeamMember()
var
Item: Record Item;
AssemblyItem: Record Item;
FromSalesHeader: Record "Sales Header";
FromSalesLine: Record "Sales Line";
ToSalesHeader: Record "Sales Header";
ToSalesLine: Record "Sales Line";
AssemblyHeader: Record "Assembly Header";
AssemblyLine: Record "Assembly Line";
LibraryLowerPermissions: Codeunit "Library - Lower Permissions";
Qty: Decimal;
begin
// [FEATURE] [Assemble-to-Order] [Copy Document] [Permissions]
// [SCENARIO] AB#630947: A user restricted to the D365 Team Member permission set can copy a sales quote whose
// line has an assemble-to-order link built from an item component, and the copy reproduces the ATO link and
// the item assembly line on the target line.
Initialize();

// [GIVEN] Assemble-to-order item with a single item component (typical ATO BOM that reads item data)
LibraryInventory.CreateItem(Item);
Item.Validate("Replenishment System", Item."Replenishment System"::Assembly);
Item.Validate("Assembly Policy", Item."Assembly Policy"::"Assemble-to-Order");
Item.Modify(true);
LibraryAssembly.CreateAssemblyList(
AssemblyItem."Costing Method"::Standard, Item."No.", true, 1, 0, 0, LibraryRandom.RandInt(5), '', '');

// [GIVEN] Source sales quote with the ATO item; validating the item auto-creates the ATO link
Qty := LibraryRandom.RandIntInRange(2, 10);
LibrarySales.CreateSalesDocumentWithItem(
FromSalesHeader, FromSalesLine, FromSalesHeader."Document Type"::Quote, LibrarySales.CreateCustomerNo(),
Item."No.", Qty, '', WorkDate());

// [GIVEN] Empty target sales quote created while the user still has full permissions
CreateEmptySalesHeader(ToSalesHeader, ToSalesHeader."Document Type"::Quote);
Commit();

// [GIVEN] User is now restricted to the D365 Team Member plan (regression harness for AB#630947)
LibraryE2EPlanPermissions.SetTeamMemberPlan();
Comment thread
Shikhverma marked this conversation as resolved.

// [WHEN] Copy Document is executed for the source quote into the target quote
CopyDocumentMgt.SetProperties(true, false, false, false, true, false, false);
CopyDocumentMgt.CopySalesDoc("Sales Document Type From"::Quote, FromSalesHeader."No.", ToSalesHeader);

// [THEN] The copied line exists on the target quote with the same quantity and Qty. to Assemble to Order...
LibraryLowerPermissions.SetO365Full();
ToSalesLine.SetRange("Document Type", ToSalesHeader."Document Type");
ToSalesLine.SetRange("Document No.", ToSalesHeader."No.");
ToSalesLine.SetRange(Type, ToSalesLine.Type::Item);
ToSalesLine.SetRange("No.", Item."No.");
Assert.RecordCount(ToSalesLine, 1);
ToSalesLine.FindFirst();
ToSalesLine.TestField(Quantity, Qty);
ToSalesLine.TestField("Qty. to Assemble to Order", Qty);

// [THEN] ...an Assembly Header is linked to the copied sales line...
Assert.IsTrue(
ToSalesLine.AsmToOrderExists(AssemblyHeader),
'Assemble-to-Order link should exist for the copied sales line.');

// [THEN] ...and the linked assembly order reproduces the item component line
Comment thread
Shikhverma marked this conversation as resolved.
AssemblyLine.SetRange("Document Type", AssemblyHeader."Document Type");
AssemblyLine.SetRange("Document No.", AssemblyHeader."No.");
AssemblyLine.SetRange(Type, AssemblyLine.Type::Item);
Assert.RecordCount(AssemblyLine, 1);
end;

[Test]
[HandlerFunctions('MessageHandler')]
[Scope('OnPrem')]
procedure CopyArchivedSalesQuoteWithATOAsTeamMember()
var
Item: Record Item;
AssemblyItem: Record Item;
FromSalesHeader: Record "Sales Header";
FromSalesLine: Record "Sales Line";
SalesHeaderArchive: Record "Sales Header Archive";
ToSalesHeader: Record "Sales Header";
ToSalesLine: Record "Sales Line";
AssemblyHeader: Record "Assembly Header";
ArchiveManagement: Codeunit ArchiveManagement;
LibraryLowerPermissions: Codeunit "Library - Lower Permissions";
Qty: Decimal;
begin
// [FEATURE] [Assemble-to-Order] [Copy Document] [Permissions] [Archive]
// [SCENARIO] AB#630947: A user restricted to the D365 Team Member permission set can copy an archived sales quote
// whose line has an assemble-to-order link, exercising the separately elevated CopySalesDocSalesLineArchive path,
// and the copy reproduces the ATO link on the target line.
Initialize();

// [GIVEN] Assemble-to-order item with a resource component
LibraryInventory.CreateItem(Item);
Item.Validate("Replenishment System", Item."Replenishment System"::Assembly);
Item.Validate("Assembly Policy", Item."Assembly Policy"::"Assemble-to-Order");
Item.Modify(true);
LibraryAssembly.CreateAssemblyList(
AssemblyItem."Costing Method"::Standard, Item."No.", true, 0, 1, 0, LibraryRandom.RandInt(5), '', '');

// [GIVEN] Source sales quote with the ATO item; validating the item auto-creates the ATO link
Qty := LibraryRandom.RandIntInRange(2, 10);
LibrarySales.CreateSalesDocumentWithItem(
FromSalesHeader, FromSalesLine, FromSalesHeader."Document Type"::Quote, LibrarySales.CreateCustomerNo(),
Item."No.", Qty, '', WorkDate());

// [GIVEN] The source quote is archived
ArchiveManagement.StoreSalesDocument(FromSalesHeader, false);
SalesHeaderArchive.Get(FromSalesHeader."Document Type", FromSalesHeader."No.", 1, 1);

// [GIVEN] Empty target sales quote created while the user still has full permissions
CreateEmptySalesHeader(ToSalesHeader, ToSalesHeader."Document Type"::Quote);
Commit();

// [GIVEN] User is now restricted to the D365 Team Member plan (regression harness for AB#630947)
LibraryE2EPlanPermissions.SetTeamMemberPlan();

// [WHEN] Copy Document is executed for the archived quote into the target quote
// Recalculate lines is required: the sales line archive does not persist "Qty. to Assemble to Order",
// so the ATO quantity is re-derived from the item's assembly policy during the copy.
CopyDocumentMgt.SetProperties(true, true, false, false, true, false, false);
CopyDocumentMgt.SetArchDocVal(SalesHeaderArchive."Doc. No. Occurrence", SalesHeaderArchive."Version No.");
CopyDocumentMgt.CopySalesDoc("Sales Document Type From"::"Arch. Quote", SalesHeaderArchive."No.", ToSalesHeader);

// [THEN] The copied line exists on the target quote with the same quantity and Qty. to Assemble to Order...
LibraryLowerPermissions.SetO365Full();
ToSalesLine.SetRange("Document Type", ToSalesHeader."Document Type");
ToSalesLine.SetRange("Document No.", ToSalesHeader."No.");
ToSalesLine.SetRange(Type, ToSalesLine.Type::Item);
ToSalesLine.SetRange("No.", Item."No.");
Assert.RecordCount(ToSalesLine, 1);
ToSalesLine.FindFirst();
ToSalesLine.TestField(Quantity, Qty);
ToSalesLine.TestField("Qty. to Assemble to Order", Qty);

// [THEN] ...and an Assembly Header is linked to the copied sales line
Assert.IsTrue(
ToSalesLine.AsmToOrderExists(AssemblyHeader),
'Assemble-to-Order link should exist for the copied sales line.');
end;

local procedure Initialize()
var
LibraryERMCountryData: Codeunit "Library - ERM Country Data";
Expand Down
Loading