Skip to content

[CZ tests] Make advance-payment posting fixtures self-contained - #11370

Draft
Prangshuman Das (t-prda) wants to merge 1 commit into
mainfrom
prdas/646383-cz-posting-fixture
Draft

[CZ tests] Make advance-payment posting fixtures self-contained#11370
Prangshuman Das (t-prda) wants to merge 1 commit into
mainfrom
prdas/646383-cz-posting-fixture

Conversation

@t-prda

@t-prda Prangshuman Das (t-prda) commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

AB#646383

Make the Czech advance-payment test libraries create their own general posting fixture when a suitable one is absent.

In the purchase and sales libraries' CreateGLAccount, replace LibraryERM.FindGeneralPostingSetup with the existing LibraryERM.FindGeneralPostingSetupInvtBase. That helper reuses a suitable setup or creates posting groups and configured G/L accounts through existing test-library routines.

Exactly two test-library lines change. No production posting logic, test-runner isolation, test exclusions, NAV selectors, or company configuration changes.

Evidence and validation

Before this fix, fourteen existing blocked/privacy customer/vendor scenarios in CUs 148108 and 148109 failed before their business assertions because no nonblank General Posting Setup pair existed. The failure persisted in run 34569356813 after discovery was isolated from the primary fixture.

The predecessor CZ test suite creates posting setups. Source inspection shows the baseline's extra Disabled pass can leave runner 130451 selected for subsequent calls; the auth harness uses ordinary Codeunit isolation (130450), which must not depend on another suite's writes. Exact baseline CZ suite-state snapshots were not captured, so the full state transition is not claimed proved.

The fixture fix removes the unconditional dependency on existing data regardless of that runner-history explanation. The chosen find-or-create helper is already used by the inventory test library and is present in the Czech Application Test Library.

Source-equivalence and whitespace checks passed: only the two helper calls changed. All fourteen formerly failing scenarios now pass in combined auth CI, CZ Default, on head 25916aeb85. The lane still fails six separate Expense permission tests, not these advance-payment scenarios.

Standalone CI passed on attempt 2 at 2026-09-11T19:28:34Z after the AU timing-test retry. That retry was not initiated by this assistant. Combined auth CI remains failed on the 12 known Expense methods, not these fourteen Czech scenarios. No local NST result is claimed.

Relationship to API authentication work

This independently reviewable test-fixture prerequisite targets main. Its commit 9b196da5f3 is included in #10085 at b85fcfbac6 to validate under the corrected isolation behavior. It is not folded into the authentication provider or the production application.

The separately tracked CU 148339 compilation prerequisite is #11340. The auth branch includes that prerequisite; this two-line PR does not duplicate it. Coverage review recorded no Expense cases in the standalone typed artifacts, so its green workflow is not evidence that the broader auth run's Expense failures are fixed.

Use the existing find-or-create general posting setup helper in the sales and purchase test libraries instead of requiring data left by another test suite. No production logic or isolation settings change.

AB#646383

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
Prangshuman Das (t-prda) added a commit that referenced this pull request Sep 11, 2026
Bring in PR #11370 so the advance-payment tests find or create their own posting fixture under Codeunit isolation. Preserve production logic, authentication behavior, exclusions and scheduler policy.

AB#646383

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3952f078-a881-4da8-ad96-13b727e48a91
@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 11, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant