Skip to content

[Expense Agent tests] Fix action-result assertions for runtime compilation #11340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Prangshuman Das (t-prda) wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Expense Agent tests] Fix action-result assertions for runtime compilation #11340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4ed3c3
Fix Travel Request action-result assertions for runtime compilation
t-prda Sep 10, 2026
86497ab
Compare formatted web service action results using the supported intr…
t-prda Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Apps/W1/ExpenseAgent/test/src/SpendRequestTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ codeunit 148339 "Spend Request Test"
TravelRequestsAPI.ApproveTravelRequest(ActionContext, ApproverExpenseUser."No.");

// [THEN] The request is approved with its audit fields and a linked report.
Assert.AreEqual(WebServiceActionResultCode::Updated, ActionContext.GetResultCode(), TravelRequestActionResultMsg);
Assert.AreEqual(Format(WebServiceActionResultCode::Updated), Format(ActionContext.GetResultCode()), TravelRequestActionResultMsg);
SpendRequest.Get(SpendRequest."No.");
Assert.AreEqual(SpendRequest.Status::Approved, SpendRequest.Status, 'The travel request should be approved through the page action.');
Assert.AreEqual(UserSecurityId(), SpendRequest."Approved/Rejected by User ID", 'The approving user should be recorded.');
Expand Down Expand Up @@ -789,7 +789,7 @@ codeunit 148339 "Spend Request Test"
TravelRequestsAPI.SubmitTravelRequest(ActionContext, ExpenseUser."No.");

// [THEN] The request is released with its submission audit fields.
Assert.AreEqual(WebServiceActionResultCode::Updated, ActionContext.GetResultCode(), TravelRequestActionResultMsg);
Assert.AreEqual(Format(WebServiceActionResultCode::Updated), Format(ActionContext.GetResultCode()), TravelRequestActionResultMsg);
SpendRequest.Get(SpendRequest."No.");
Assert.AreEqual(SpendRequest.Status::Released, SpendRequest.Status, 'The travel request should be released through the page action.');
Assert.AreEqual(ExpenseUser."No.", SpendRequest."Submitted By Expense User No.", 'The submitting expense user should be recorded.');
Expand Down Expand Up @@ -898,7 +898,7 @@ codeunit 148339 "Spend Request Test"
TravelRequestsAPI.RejectTravelRequest(ActionContext, ApproverExpenseUser."No.", RejectReason);

// [THEN] The action returns Updated and the request records the rejection details.
Assert.AreEqual(WebServiceActionResultCode::Updated, ActionContext.GetResultCode(), TravelRequestActionResultMsg);
Assert.AreEqual(Format(WebServiceActionResultCode::Updated), Format(ActionContext.GetResultCode()), TravelRequestActionResultMsg);
SpendRequest.Get(SpendRequest."No.");
Assert.AreEqual(SpendRequest.Status::Rejected, SpendRequest.Status, TravelRequestRejectedMsg);
Assert.AreEqual(UserSecurityId(), SpendRequest."Approved/Rejected by User ID", TravelRequestRejectionUserMsg);
Expand Down
Loading