Skip to content

[29.0] - Bug 649665: Upgrade from v28.4 to v29.0 fails for Expense Agent (Preview) (US) - #11289

Merged
Prangshuman Das (t-prda) merged 1 commit into
releases/29.0from
bugs/Bug-649665-Upgrade-from-v28.4-to-v29.0-fails-Expense-Agent-(Preview)-(US)-29.0
Sep 10, 2026
Merged

[29.0] - Bug 649665: Upgrade from v28.4 to v29.0 fails for Expense Agent (Preview) (US)#11289
Prangshuman Das (t-prda) merged 1 commit into
releases/29.0from
bugs/Bug-649665-Upgrade-from-v28.4-to-v29.0-fails-Expense-Agent-(Preview)-(US)-29.0

Conversation

@v-rohangarg20

@v-rohangarg20 v-rohangarg20 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

AB#649665 Backport of the Expense Agent upgrade fix for the 29.0 release branch.

Changes

  • Add the missing dependency entries required for the v28.4-to-v29.0 upgrade path.
  • Keep the Expense Agent app metadata aligned with the release configuration.

Validation

  • Backport of the fix from the main PR.
  • Created the 29.0 release backport PR.

@v-rohangarg20
v-rohangarg20 requested a review from a team September 9, 2026 17:22
@v-rohangarg20
v-rohangarg20 requested a review from a team as a code owner September 9, 2026 17:22
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area labels Sep 9, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Sep 9, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This PR grants the localized Expense Agent and Expense Agent Demo Data apps access to the W1 Expense Agent internals needed during upgrade compilation. The added manifest entries match the localized app IDs and names, and the change does not alter AL runtime logic.

Problem-solution fit

Fit: Strong

The reported failure is a compile-time internal-access problem, and the diff fixes that access at the manifest boundary. The scope is limited to the affected localized apps and matches the same release uptake pattern.

Suggestions

None.

Risk assessment and necessity

Risk: Low. The change broadens internal visibility only to localized Microsoft app manifests, so the main regression surface is an incorrect app ID or name. The added entries match the localized manifests, and no posting, amount, data-upgrade, or event logic changes.

Necessity: The change is needed so localized Expense Agent packages can compile during the v28.4-to-v29.0 upgrade path. The manifest-only scope is the narrow fix for that failure.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11289 round=1 by=alexei-dobriansky at=2026-09-09T19:18:43Z lastSha=1f62a7efb78767dd9c90b605e487742724edab51 reviewKey=7ec205a12fce7dc2e15273e2383381d969429c7667b359e3867b7e7b945a59b5 suggestions=none

@v-rohangarg20
v-rohangarg20 marked this pull request as draft September 10, 2026 13:58
@v-rohangarg20
v-rohangarg20 marked this pull request as ready for review September 10, 2026 14:21
@t-prda
Prangshuman Das (t-prda) merged commit a4b7fd7 into releases/29.0 Sep 10, 2026
340 of 342 checks passed
@t-prda
Prangshuman Das (t-prda) deleted the bugs/Bug-649665-Upgrade-from-v28.4-to-v29.0-fails-Expense-Agent-(Preview)-(US)-29.0 branch September 10, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants