[29.x] - Bug 649664: Upgrade from v28.4 to v29.0 fails for Expense Agent (Preview) (US) - #11288
Conversation
Good Sense Reviewer - Round 1Recommendation: AcceptWhat this PR doesThis change lets the country Expense Agent and country demo-data apps read the internal W1 Expense Agent symbols they already depend on during the v28.4-to-v29.0 upgrade path. The two changed manifests add internalsVisibleTo entries only; no AL runtime logic, posting flow, or data mutation changes. The direction is correct for AL internal access: the provider apps now list the consumer apps that need visibility. The added app IDs and names match the country-specific Expense Agent packages on the target branch, and the demo-data visibility is also added from the W1 demo-data app to the country demo-data apps. Problem-solution fitFit: Strong The reported failure is a compile-time internal-access problem in the upgrade path. The fix addresses that root cause by granting internal visibility from the W1 provider manifests to the dependent country apps instead of changing runtime behavior. SuggestionsNo suggestions. Risk assessment and necessityRisk: Low. The change only widens internal visibility in src/Apps/W1/ExpenseAgent/app/app.json and src/Apps/W1/ExpenseAgent/demo data/app.json for existing dependent apps; it does not change business logic, posting, data upgrade code, or BaseApp event behavior. Necessity: The change is needed so the affected country packages can compile when they reference internal W1 Expense Agent objects during upgrade. This is a targeted metadata fix for the reported upgrade failure.
|
Summary
AB#649664 Backport of the Expense Agent upgrade fix for the 29.x release branch.
Changes
Validation