Skip to content

[29.x] - Bug 649664: Upgrade from v28.4 to v29.0 fails for Expense Agent (Preview) (US) - #11288

Open
v-rohangarg20 wants to merge 1 commit into
releases/29.xfrom
bugs/Bug-649664-Upgrade-from-v28.4-to-v29.0-fails-Expense-Agent-(Preview)-(US)-29.x
Open

[29.x] - Bug 649664: Upgrade from v28.4 to v29.0 fails for Expense Agent (Preview) (US)#11288
v-rohangarg20 wants to merge 1 commit into
releases/29.xfrom
bugs/Bug-649664-Upgrade-from-v28.4-to-v29.0-fails-Expense-Agent-(Preview)-(US)-29.x

Conversation

@v-rohangarg20

@v-rohangarg20 v-rohangarg20 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

AB#649664 Backport of the Expense Agent upgrade fix for the 29.x release branch.

Changes

  • Add the missing dependency entries required for the v28.4-to-v29.0 upgrade path.
  • Keep the Expense Agent app metadata aligned with the release configuration.

Validation

  • Backport of the fix from the main PR.
  • Created the 29.x release backport PR.

@v-rohangarg20
v-rohangarg20 requested a review from a team September 9, 2026 17:21
@v-rohangarg20
v-rohangarg20 requested a review from a team as a code owner September 9, 2026 17:21
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area labels Sep 9, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 9, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change lets the country Expense Agent and country demo-data apps read the internal W1 Expense Agent symbols they already depend on during the v28.4-to-v29.0 upgrade path. The two changed manifests add internalsVisibleTo entries only; no AL runtime logic, posting flow, or data mutation changes.

The direction is correct for AL internal access: the provider apps now list the consumer apps that need visibility. The added app IDs and names match the country-specific Expense Agent packages on the target branch, and the demo-data visibility is also added from the W1 demo-data app to the country demo-data apps.

Problem-solution fit

Fit: Strong

The reported failure is a compile-time internal-access problem in the upgrade path. The fix addresses that root cause by granting internal visibility from the W1 provider manifests to the dependent country apps instead of changing runtime behavior.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: Low. The change only widens internal visibility in src/Apps/W1/ExpenseAgent/app/app.json and src/Apps/W1/ExpenseAgent/demo data/app.json for existing dependent apps; it does not change business logic, posting, data upgrade code, or BaseApp event behavior.

Necessity: The change is needed so the affected country packages can compile when they reference internal W1 Expense Agent objects during upgrade. This is a targeted metadata fix for the reported upgrade failure.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11288 round=1 by=alexei-dobriansky at=2026-09-09T19:17:37.5892253Z lastSha=f44d15cbf6f1363b50e5dfa9098b7bc4120aad09 reviewKey=6465641c6d35a46fa8c3866d2333e080bbeeb417e0afe2ded1c92027f8c9c7ed suggestions=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants