[Master] - Bug 649653: Upgrade from v28.4 to v29.0 fails for Expense Agent (Preview) (US)

[v-rohangarg20]

Summary

AB#649653 Fixes the upgrade failure for Expense Agent (Preview) when moving from v28.4 to v29.0.

Changes

• Update the affected Expense Agent upgrade logic to be compatible with v29.0.
• Keep the US app metadata aligned with the current preview package configuration.

Validation

• Verified the branch is clean and ready for review.
• PR created from the dedicated bugfix branch targeting main.

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change lets obsolete country-specific Expense Agent and country demo data apps compile when they still reference internal W1 Expense Agent objects during upgrade. It grants internalsVisibleTo from the W1 app to the ten country apps and their demo data apps, and from the W1 demo data app to the ten country demo data apps.

The added IDs and names match the country app manifests, and the change is limited to package metadata. It addresses the reported AL0161 access failures without changing runtime behavior or posting/data logic.

Problem-solution fit

Fit: Strong

The reported upgrade failure is caused by country packages compiling against internal W1 objects. The diff targets that exact access boundary and covers all matching country packages, so the fix is complete for the visible package set.

Suggestions

None.

Risk assessment and necessity

Risk: This is a metadata-only change in src/Apps/W1/ExpenseAgent/app/app.json and src/Apps/W1/ExpenseAgent/demo data/app.json. It widens internal access only to Microsoft-owned Expense Agent country packages, so compatibility risk is low and there is no BaseApp publisher or runtime flow to verify.

Necessity: The access grant is needed because the country packages still compile against internal W1 Expense Agent objects during upgrade. The scope is appropriate because it only updates manifests and matches the available country app and demo data packages.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11283 round=1 by=alexei-dobriansky at=2026-09-09T19:16:14Z lastSha=3bacb04c2209a406f803e7b6a62b970e44e28da8 reviewKey=1c9072bda42ea65929092921ea9a890249c94edc58297764b371499b89ba593d suggestions=