[29.0] Backport Chat v2 privacy notice behavior changed to not auto agree for Eval companies - #11270
Conversation
…mpanies (#11204) Fixes: [AB#649164](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/649164) Description: Turning the skip the check for eval companies to false for copilot chat privacy notice essentially changing the default behavior of Eval company to the current behavior of non-Eval company.
Good Sense Reviewer - Round 1Recommendation: AcceptWhat this PR doesThe change makes the Microsoft Copilot privacy notice use the normal default approval rules for evaluation companies instead of the blanket evaluation-company approval shortcut. The same per-notice rule is used in both IsCapabilityActive and EnsurePrivacyNoticesApproved, so the status check and the approval prompt path stay aligned. The code compares each required notice with the Microsoft Copilot notice ID and passes SkipCheckInEval=false only for that notice. That still allows the existing default approval logic to decide by region, while other required notices keep the current evaluation-company behavior. The change is narrow and matches the fixed behavior already present on the source branch. Problem-solution fitFit: Strong The reported problem is that Copilot chat privacy approval should not be auto-agreed only because the company is an evaluation company. The diff changes both places that call the privacy notice API, and it limits the behavior change to the Microsoft Copilot privacy notice. SuggestionsNone. Risk assessment and necessityRisk: Low to moderate. The change is in System Application Copilot privacy gating, so a mistake could change whether evaluation companies can use Copilot chat without an explicit approval. The branch is small, uses the existing privacy notice API contract, leaves admin and user decisions unchanged, and has no BaseApp event or Sales/Purchase/Service analog dependency. Necessity: The change is needed to stop the broad evaluation-company shortcut for the Microsoft Copilot notice while preserving it for other notices. The scope is right because it updates the two call sites that check or request the required notices for a capability.
|
Fixes: AB#649639
Backport commit: d5ea8cc
Backports new behavior for chat v2 privacy policy to treat Eval companies as non-Eval companies