Skip to content

[29.0] Backport Chat v2 privacy notice behavior changed to not auto agree for Eval companies - #11270

Open
Tymon Mikula (Kimi310) wants to merge 1 commit into
releases/29.0from
private/t-tmikula/HotfixEEAPolicyChat
Open

[29.0] Backport Chat v2 privacy notice behavior changed to not auto agree for Eval companies#11270
Tymon Mikula (Kimi310) wants to merge 1 commit into
releases/29.0from
private/t-tmikula/HotfixEEAPolicyChat

Conversation

@Kimi310

@Kimi310 Tymon Mikula (Kimi310) commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Fixes: AB#649639
Backport commit: d5ea8cc

Backports new behavior for chat v2 privacy policy to treat Eval companies as non-Eval companies

…mpanies (#11204)

Fixes:
[AB#649164](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/649164)

Description: Turning the skip the check for eval companies to false for
copilot chat privacy notice essentially changing the default behavior of
Eval company to the current behavior of non-Eval company.
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

The change makes the Microsoft Copilot privacy notice use the normal default approval rules for evaluation companies instead of the blanket evaluation-company approval shortcut. The same per-notice rule is used in both IsCapabilityActive and EnsurePrivacyNoticesApproved, so the status check and the approval prompt path stay aligned.

The code compares each required notice with the Microsoft Copilot notice ID and passes SkipCheckInEval=false only for that notice. That still allows the existing default approval logic to decide by region, while other required notices keep the current evaluation-company behavior. The change is narrow and matches the fixed behavior already present on the source branch.

Problem-solution fit

Fit: Strong

The reported problem is that Copilot chat privacy approval should not be auto-agreed only because the company is an evaluation company. The diff changes both places that call the privacy notice API, and it limits the behavior change to the Microsoft Copilot privacy notice.

Suggestions

None.

Risk assessment and necessity

Risk: Low to moderate. The change is in System Application Copilot privacy gating, so a mistake could change whether evaluation companies can use Copilot chat without an explicit approval. The branch is small, uses the existing privacy notice API contract, leaves admin and user decisions unchanged, and has no BaseApp event or Sales/Purchase/Service analog dependency.

Necessity: The change is needed to stop the broad evaluation-company shortcut for the Microsoft Copilot notice while preserving it for other notices. The scope is right because it updates the two call sites that check or request the required notices for a capability.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11270 round=1 by=alexei-dobriansky at=2026-09-09T22:21:26.7347865Z lastSha=23b5fc25764d8d75c9b43bb623647c73514297d3 reviewKey=f8520c092bd69a10c7ad934a932f82fc755e6e78d96cf3a6d4157034aaec47b0 suggestions=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: System Application Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants