Skip to content

Move review ownership to CODEOWNERS - #11264

Open
Jesper Schulz-Wedde (JesperSchulz) wants to merge 6 commits into
mainfrom
jesperschulz-al-code-ownership
Open

Move review ownership to CODEOWNERS#11264
Jesper Schulz-Wedde (JesperSchulz) wants to merge 6 commits into
mainfrom
jesperschulz-al-code-ownership

Conversation

@JesperSchulz

@JesperSchulz Jesper Schulz-Wedde (JesperSchulz) commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add @microsoft/dynamics-365-business-central as the repository fallback when no more specific CODEOWNER exists
  • move AL review routes from the Official Branches ruleset into CODEOWNERS, including API, disabled tests, upgrade, GDL, demo-tool/data, and dotnet*.al ownership
  • keep existing Power BI, AI/developer-experience, e-document, modules, entitlement, SCM, Integrations, Finance, and specialist mappings authoritative through CODEOWNERS' last-match-wins ordering
  • make ruleset-controlled special paths explicitly ownerless in CODEOWNERS so they do not request both the fallback team and the ruleset reviewer
  • remove redundant Power BI rules and condense the guidance

Ruleset coordination

Update the Official Branches ruleset (ID 17834252) as follows:

  • enable require_code_owner_review
  • remove the blanket * required reviewer
  • remove the AL file/folder-specific required reviewers after migrating their ownership to CODEOWNERS
  • retain only these special-path required reviewers:
    • App Rulesets: /src/rulesets/
    • Code Review Tools: /tools/Code Review
    • Engineering Systems: .AL-Go/, *.ps1, /.azuredevops, /.github, /build, /CODEOWNERS

Unlike the ruleset's additive * required-reviewer entry, the CODEOWNERS fallback is replaced by any later matching rule. The 539 tracked files covered by the retained special-path rules are explicitly ownerless in CODEOWNERS; every other tracked file resolves to a CODEOWNER.

Fixes AB#647781.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction Team: Other GitHub request for other area than SCM, Finance or Integration labels Sep 9, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Comment thread CODEOWNERS
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@JesperSchulz Jesper Schulz-Wedde (JesperSchulz) changed the title Add fallback code ownership for AL files Move AL review ownership to CODEOWNERS Sep 9, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@JesperSchulz Jesper Schulz-Wedde (JesperSchulz) changed the title Move AL review ownership to CODEOWNERS Move review ownership to CODEOWNERS Sep 9, 2026
Jesper Schulz-Wedde and others added 2 commits September 9, 2026 13:56
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction Team: Other GitHub request for other area than SCM, Finance or Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants