Skip to content

Update ConnectivityAppDefinitions.Codeunit.al - #11263

Open
VytenisLegas wants to merge 1 commit into
microsoft:mainfrom
VytenisLegas:patch-1
Open

Update ConnectivityAppDefinitions.Codeunit.al#11263
VytenisLegas wants to merge 1 commit into
microsoft:mainfrom
VytenisLegas:patch-1

Conversation

@VytenisLegas

Copy link
Copy Markdown

Summary:
Added Bankfeed to 10 more countries in ConnectivityApps: BG, CA, FR, GR, IT, MT, NL, NO, UA, ZA

Work Item(s):
Fixes #

Summary:
Added Bankfeed to 10 more countries in ConnectivityApps: BG, CA, FR, GR, IT, MT, NL, NO, UA, ZA

Work Item(s):
Fixes
@VytenisLegas
VytenisLegas requested a review from a team September 9, 2026 10:59
@VytenisLegas
VytenisLegas requested a review from a team as a code owner September 9, 2026 10:59
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@github-actions github-actions Bot added Team: Integrations GitHub request for Integrations area needs-approval Workflow runs require maintainer approval to start and removed needs-approval Workflow runs require maintainer approval to start labels Sep 9, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

The change adds Softera Bankfeed availability for more countries and adds matching description translations. The implementation updates the same metadata strings that RegisterApp later converts to enums, but some new tokens do not exist in those enums, so the definitions can fail while loading.

Problem-solution fit

Fit: Partial

The requested rollout is clear, and the edit is in the right registration method. The solution is incomplete because several changed values cannot be evaluated by the existing enums.

Suggestions

S1 (🔴 High): Use valid country and localization values
RegisterApp evaluates these comma-separated values into enums. GR, UA, and NA are not valid values here, so loading the connectivity app definitions can fail. Use existing values, for example EL for Greece and CA for Canada localization, or add the missing enum values before referencing them.

Risk assessment and necessity

Risk: This touches metadata that is loaded for the Connectivity Apps list. If the invalid values remain, users can hit a runtime failure before the list is built; there is no posting, ledger, or event-subscriber risk.

Necessity: The expansion is reasonable because it makes an existing banking app available in more countries. The scope is narrow, but it must use supported country/region and localization values before merge.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11263 round=1 by=alexei-dobriansky at=2026-09-09T22:21:03.7176173Z lastSha=e0d3847c7f526c7a5e510c6b231cc61593c24ae0 reviewKey=83b21bdb53f2bcfd77dcf0a88389b2d47eb41ab63c2cc564515086137eacc223 suggestions=S1@f05258fc

@github-actions github-actions Bot added needs-approval Workflow runs require maintainer approval to start and removed needs-approval Workflow runs require maintainer approval to start labels Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants