Postcode Configuration Page: display the stored provider selection on open - #11259
Draft
sergey-idealpostcodes wants to merge 1 commit into
Conversation
OnOpenPage only set the ServiceKeyText display variable in the record-missing and not-configured branches, so with a configured provider the Address Provider field rendered empty. Load the stored service key for display; PrevValue keeps its cancel-restore role. Same fix in the W1 and GB pages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Issue #11255 is not valid. Please make sure you link an issue that exists, is open and is approved. |
github-actions
Bot
added
Team: Integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11255
OnOpenPageof page 9143 "Postcode Configuration Page W1" and page 10501 "Postcode Configuration Page" (GB) sets theServiceKeyTextdisplay variable only in the record-missing / not-configured branches, so with a configured provider the Address Provider field renders empty (an underscore in the web client). The stored key was already read intoPrevValue— it was just never displayed.One-line fix in each page: load the stored service key into
ServiceKeyTextand keepPrevValuefor cancel-restore. Together with #11254, the field then readsIdealPostcodesfor that provider.🤖 Generated with Claude Code