[29.0] bug 649305 - Add Report Address Source functionality to Company Information - #11252
[29.0] bug 649305 - Add Report Address Source functionality to Company Information#11252David Holuša (DavidHolusa) wants to merge 3 commits into
Conversation
Good Sense Reviewer - Round 1Recommendation: Request ChangesWhat this PR doesThis adds a company-level Report Address Source CZL setting and a Format Address subscriber so CZ document reports can choose the company address instead of the responsibility center address. The hook is the right place because the CZ sales, purchase, and service reports already call GetCompanyAddr, and the BaseApp publisher fires before the responsibility-center fallback. The branch for Company Information is correct when selected, but the enum order makes that branch the default, which does not preserve the expected behavior. Problem-solution fitFit: Partial The new setting and central subscriber match the reported need to choose the address source for CZ document reports. The solution is incomplete because existing companies will default to Company Information, not to the previous Responsibility Center behavior. SuggestionsS1 (🔴 High): Default reverses existing address behavior S2 (🟠 Moderate): Default behavior needs regression coverage Risk assessment and necessityRisk: The subscriber changes the central Format Address path used by CZ sales, purchase, and service reports. The BaseApp publisher exists and fires before the standard responsibility-center logic, so the new handler controls the address source when it sets IsHandled. With the current enum order, existing companies can get the company address instead of the responsibility-center address on reports after upgrade. Necessity: The change is needed because a company may need its billing address on CZ document reports even when documents use responsibility centers. The scope is reasonable and centralized, but it must keep the previous default to avoid unexpected report output.
|
What & why
Adds a new Report Address Source option to the Company Information table and page for the CZ Core Localization Pack. This allows users to choose whether the address printed on CZ sales and purchase document reports is taken from Company Information or from the Responsibility Center.
Previously, when a Responsibility Center was set on a document, its address was always used in printed reports. However, CZ legislation requires the billing address to be stated, and customers use Responsibility Centers in various ways — making it not always appropriate to override the company address. This change introduces a configurable setting so each company can control the behavior.
Changes:
Report Address Source CZLwith options:Company Information,Responsibility CenterReport Address Source CZLon the Company Information table (79)Importance = Additional)Linked work
Fixes AB#649305
How I validated this
What I tested and the outcome
Risk & compatibility
Responsibility Centerto maintain backward compatibility with existing behavior after the previous redesign.