[29.x] bug 649305 - Add Report Address Source functionality to Company Information - #11251
Conversation
Good Sense Reviewer - Round 1Recommendation: Request ChangesWhat this PR doesThis change adds a Company Information setting for CZ report addresses and uses a Format Address subscriber to choose Company Information when that setting is selected. The subscriber is placed before the existing Responsibility Center fallback, so the new option can work. The problem is the new enum makes Company Information the default, which changes existing behavior instead of preserving it. Problem-solution fitFit: Partial The change adds the requested setting and connects it to the shared report address flow. It does not fully fit because the default value should keep using Responsibility Center until a company chooses Company Information. SuggestionsS1 (🔴 High): Default report address source flips existing behavior Risk assessment and necessityRisk: This affects CZ sales, purchase, and service reports that call Format Address.GetCompanyAddr. The W1 publisher was verified: it fires before the Responsibility Center branch and exits when IsHandled is true, so the new subscriber can change the address used by all those reports. With the current enum ordering, existing companies can silently print Company Information instead of Responsibility Center. Necessity: The setting is needed because some companies must print the company billing address even when a document has a Responsibility Center. The scope is suitable, but the default must preserve the existing Responsibility Center behavior.
|
What & why
Adds a new Report Address Source option to the Company Information table and page for the CZ Core Localization Pack. This allows users to choose whether the address printed on CZ sales and purchase document reports is taken from Company Information or from the Responsibility Center.
Previously, when a Responsibility Center was set on a document, its address was always used in printed reports. However, CZ legislation requires the billing address to be stated, and customers use Responsibility Centers in various ways — making it not always appropriate to override the company address. This change introduces a configurable setting so each company can control the behavior.
Changes:
Report Address Source CZLwith options:Company Information,Responsibility CenterReport Address Source CZLon the Company Information table (79)Importance = Additional)Linked work
Fixes AB#649305
How I validated this
What I tested and the outcome
Risk & compatibility
Responsibility Centerto maintain backward compatibility with existing behavior after the previous redesign.