Skip to content

[29.x] Sync backport #10990 with latest Expense VAT setup and Shopify VAT-posting test updates - #11239

Closed
Alexander Yakunin (Alexander-Ya) with Copilot wants to merge 1 commit into
releases/29.xfrom
copilot/backportreleases29x10990sync
Closed

[29.x] Sync backport #10990 with latest Expense VAT setup and Shopify VAT-posting test updates#11239
Alexander Yakunin (Alexander-Ya) with Copilot wants to merge 1 commit into
releases/29.xfrom
copilot/backportreleases29x10990sync

Conversation

Copilot AI commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This updates backport PR #10994 to match the current scope of PR #10990 on main, bringing the releases/29.x branch in sync for Expense Agent VAT/GST setup behavior and dependent Shopify test setup changes.
The backport now includes all 9 intended files and keeps the release-branch intent intact.

  • Expense Agent category/subcategory alignment

    • Added hotel-specific subcategory codes (HOTEL-PARK, HOTELOTHER) and corresponding accessors.
    • Updated VAT-rate mapping to use hotel-specific parking/other subcategories.
    • Normalized room service token to ROOM-SERVICE.
  • Expense VAT/GST account and posting-setup behavior

    • Replaced virtual single EXPENSE VAT account usage with lookup/use of seeded per-rate Expense VAT/GST posting accounts.
    • Added GetExpenseVATAccountName(VATPercent) with VAT/GST naming by country context.
    • Updated VAT posting setup creation/update logic to carry forward sales VAT account where available and set purchase account by rate.
  • Contoso demo-data flow for VAT countries

    • Added IsVATCountry() gate based on Contoso demo company type.
    • Added Expense VAT/GST account seeding in the 5650–5659 range per country VAT-rate set.
    • Updated module master-data flow to set default VAT business posting group (Domestic) and then run Create Expense VAT Rates only for VAT countries.
  • Shopify test setup compatibility

    • Added CreateVATPostingSetup overload separating general posting groups from VAT posting groups.
    • Updated invoice/shipping tests to use the new overload and aligned setup calls accordingly.
if not CreateExpenseCountryData.IsVATCountry() then
    exit;

ExpenseAgentSetup.Get();
ExpenseAgentSetup.Validate("Default VAT Bus. Posting Group", CreateVATPostingGroups.Domestic());
ExpenseAgentSetup.Modify(true);
Commit();
Codeunit.Run(Codeunit::"Create Expense VAT Rates");

Copilot AI changed the title [WIP] Sync changes from PR #10990 into backport PR #10994 [29.x] Sync backport #10990 with latest Expense VAT setup and Shopify VAT-posting test updates Sep 9, 2026
@github-actions github-actions Bot added needs-approval Workflow runs require maintainer approval to start and removed needs-approval Workflow runs require maintainer approval to start labels Sep 9, 2026
@Alexander-Ya

Copy link
Copy Markdown
Contributor

Incomplete PR created, should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-approval Workflow runs require maintainer approval to start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants