Skip to content

[29.X]- The Available to Take logic is incorrect or inaccurate in the Pick Worksheet as it includes Ship and Receive bin inventory - #11238

Open
Fixes4BC (neeleshsinghal) wants to merge 4 commits into
releases/29.xfrom
bugs/Bug-647203-Available-to-Take-logic-on-inaccurate-in-the-Pick-Worksheetv29
Open

[29.X]- The Available to Take logic is incorrect or inaccurate in the Pick Worksheet as it includes Ship and Receive bin inventory#11238
Fixes4BC (neeleshsinghal) wants to merge 4 commits into
releases/29.xfrom
bugs/Bug-647203-Available-to-Take-logic-on-inaccurate-in-the-Pick-Worksheetv29

Conversation

@neeleshsinghal

@neeleshsinghal Fixes4BC (neeleshsinghal) commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#647203

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@neeleshsinghal
Fixes4BC (neeleshsinghal) requested a review from a team September 9, 2026 06:07
@neeleshsinghal
Fixes4BC (neeleshsinghal) requested a review from a team as a code owner September 9, 2026 06:07
@github-actions github-actions Bot added the Team: SCM GitHub request for SCM area label Sep 9, 2026
@github-actions github-actions Bot modified the milestone: Version 29.1 Sep 9, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change makes Pick Worksheet availability for non-directed, bin-mandatory warehouse locations ignore inventory that cannot be picked from configured receipt and shipment bins. The new bin filter matches the direct pick creation logic, the picked-not-shipped adjustment avoids double removing registered picks in the shipment bin, and the inventory cap keeps received-but-not-put-away stock unavailable even when the configured receipt bin later changes.

Problem-solution fit

Fit: Strong

The reported scenario is that the worksheet shows more available quantity than the actual pick can create when inventory sits in receipt or shipment bins. The diff addresses that full mismatch while preserving configurations where receipt or shipment bins should still count because put-away or pick is not required.

Suggestions

None.

Risk assessment and necessity

Risk: The touched surface is warehouse Pick Worksheet quantity calculation for non-directed locations with bins, so a mistake could make users overstate or understate pickable inventory. The change is narrow, changes no public API or event contract, aligns with the BaseApp direct pick bin-selection filter, and is covered by W1, IT, and RU tests for configured receipt and shipment bins, receipt-bin changes, registered picks, and double-removal cases.

Necessity: The change is needed because the worksheet could report stock as available even though the standard pick flow cannot take it. The scope is appropriate: it changes only the availability calculation and matching regression tests.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11238 round=1 by=alexei-dobriansky at=2026-09-09T12:35:09.6889731Z lastSha=dc877660aaa31995fd1f88dedb2a7c3e8bb45136 reviewKey=3c7a4083aba3aef1133283220fc041ad2ece05d7f1a93c0b4e532f1151e5cbd1 suggestions=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants