[29.x] - [Bug 648542] Bug 645043: [Expense Agent] Expense User with missing Employee Posting Group is exposed through the Expense Users API and gets stuck at submission - #10882
Closed
v-rohangarg20 wants to merge 2 commits into
Conversation
… user Bug 645043: an expense user linked to an employee without an employee posting group was exposed through the Expense Users API and got stuck at submission. - Expense User."Employee No." validation now blocks employees without an employee posting group. - Added an "Employee Posting Group" lookup FlowField on Expense User and filtered it out in the Expense Users API OnOpenPage, for employees that lose the posting group later. - Added tests for both the blocked and the allowed link. (cherry picked from commit 686bbe8)
(cherry picked from commit 0ddb2af)
Contributor
|
Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link. |
Alexander Yakunin (Alexander-Ya)
temporarily deployed
to
triage
September 1, 2026 11:05 — with
GitHub Actions
Inactive
Anders (AndersLarsenMicrosoft)
had a problem deploying
to
triage
September 4, 2026 12:54 — with
GitHub Actions
Failure
Anders (AndersLarsenMicrosoft)
had a problem deploying
to
triage
September 4, 2026 12:55 — with
GitHub Actions
Failure
v-rohangarg20
had a problem deploying
to
triage
September 8, 2026 04:08 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#648542
Problem
An expense user linked to an employee without an Employee Posting Group was returned by the Expense Users API. The agent could sign that user in, but submission/posting later failed because the posting group is required.
Changes
Expense User.Employee No.validation now errors when the employee has no employee posting group, so such a link cannot be created.Employee Posting Grouplookup FlowField (field 25) onExpense Userand filtered on it inExpense Users APIOnOpenPage(FilterGroup 2, next to the existingEmployee No.filter). This also covers employees whose posting group is removed after the link was made.Tests
ExpenseUserCannotBeLinkedToEmployeeWithoutPostingGroupExpenseUserCanBeLinkedToEmployeeWithPostingGroup