Skip to content

[29.x] - [Bug 648542] Bug 645043: [Expense Agent] Expense User with missing Employee Posting Group is exposed through the Expense Users API and gets stuck at submission - #10882

Closed
v-rohangarg20 wants to merge 2 commits into
microsoft:releases/29.xfrom
v-rohangarg20:bugs/645043-expense-user-employee-posting-group-29x
Closed

Conversation

@v-rohangarg20

@v-rohangarg20 v-rohangarg20 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#648542

Problem

An expense user linked to an employee without an Employee Posting Group was returned by the Expense Users API. The agent could sign that user in, but submission/posting later failed because the posting group is required.

Changes

  • Expense User.Employee No. validation now errors when the employee has no employee posting group, so such a link cannot be created.
  • Added the Employee Posting Group lookup FlowField (field 25) on Expense User and filtered on it in Expense Users API OnOpenPage (FilterGroup 2, next to the existing Employee No. filter). This also covers employees whose posting group is removed after the link was made.
  • Updated Expense Agent demo-data ordering so employees receive posting groups before expense users are linked.

Tests

  • ExpenseUserCannotBeLinkedToEmployeeWithoutPostingGroup
  • ExpenseUserCanBeLinkedToEmployeeWithPostingGroup

… user

Bug 645043: an expense user linked to an employee without an employee posting group was exposed through the Expense Users API and got stuck at submission.

- Expense User."Employee No." validation now blocks employees without an employee posting group.
- Added an "Employee Posting Group" lookup FlowField on Expense User and filtered it out in the Expense Users API OnOpenPage, for employees that lose the posting group later.
- Added tests for both the blocked and the allowed link.

(cherry picked from commit 686bbe8)
@v-rohangarg20
v-rohangarg20 requested a review from a team September 1, 2026 10:05
@v-rohangarg20
v-rohangarg20 requested a review from a team as a code owner September 1, 2026 10:05
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Sep 1, 2026
@v-rohangarg20 v-rohangarg20 added this to the Version 29.1 milestone Sep 1, 2026
@v-rohangarg20 v-rohangarg20 added Team: Finance GitHub request for Finance area and removed From Fork Pull request is coming from a fork labels Sep 1, 2026
@github-actions github-actions Bot added the ADO: Sync Creates an Azure DevOps work item if needed and indicates that one is linked label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ADO: Sync Creates an Azure DevOps work item if needed and indicates that one is linked AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants