Skip to content

[29.x]User is unable to filter the Deferral Summary-GL Report Not Filtering Totals by Global Dimensions. #10874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fixes4BC (neeleshsinghal) merged 4 commits into from
Sep 10, 2026
Merged

[29.x]User is unable to filter the Deferral Summary-GL Report Not Filtering Totals by Global Dimensions. #10874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbac50f
Fix and Automation
neeleshsinghal Sep 1, 2026
9313742
Fix and Automation
neeleshsinghal Sep 1, 2026
81cf7c2
Merge branch 'bugs/Bug-648519-User-is-unable-to-filter-the-Deferral-S…
neeleshsinghal Sep 1, 2026
0deb1b9
Miapp
neeleshsinghal Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 92 additions & 1 deletion src/Layers/ES/Tests/ERM/TestREDSetupGenJnl.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
LibrarySetupStorage: Codeunit "Library - Setup Storage";
LibraryTimeSheet: Codeunit "Library - Time Sheet";
LibraryJournals: Codeunit "Library - Journals";
LibraryDimension: Codeunit "Library - Dimension";
DeferralUtilities: Codeunit "Deferral Utilities";
CalcMethod: Enum "Deferral Calculation Method";
DeferralDocType: Option Purchase,Sales,"G/L";
Expand Down Expand Up @@ -2263,6 +2264,22 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
VerifyDeferralSchedule("Deferral Document Type"::Purchase, PurchaseLine."Document Type".AsInteger(), PurchaseLine."Document No.", PurchaseLine."Line No.");
end;

[Test]
[HandlerFunctions('GLDeferralSummaryReportHandler')]
procedure GLDeferralSummaryReportFiltersByGlobalDimension1()
begin
// [SCENARIO 647585] Deferral Summary - G/L respects the Global Dimension 1 filter
VerifyGLDeferralSummaryReportFiltersByGlobalDimension(1);
end;

[Test]
[HandlerFunctions('GLDeferralSummaryReportHandler')]
procedure GLDeferralSummaryReportFiltersByGlobalDimension2()
begin
// [SCENARIO 647585] Deferral Summary - G/L respects the Global Dimension 2 filter
VerifyGLDeferralSummaryReportFiltersByGlobalDimension(2);
end;

local procedure Initialize()
var
AccountingPeriod: Record "Accounting Period";
Expand Down Expand Up @@ -2884,6 +2901,80 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
Assert.RecordIsEmpty(DeferralLine);
end;

local procedure VerifyGLDeferralSummaryReportFiltersByGlobalDimension(GlobalDimensionNo: Integer)
var
DimensionValue: array[2] of Record "Dimension Value";
GeneralLedgerSetup: Record "General Ledger Setup";
GenJournalBatch: Record "Gen. Journal Batch";
GenJournalLine: array[2] of Record "Gen. Journal Line";
GLAccount: Record "G/L Account";
PostedDeferralHeader: Record "Posted Deferral Header";
DeferralSummaryGL: Report "Deferral Summary - G/L";
DimensionCode: Code[20];
begin
Initialize();

// [GIVEN] Two posted deferrals with different values for the selected global dimension
GeneralLedgerSetup.Get();
case GlobalDimensionNo of
1:
DimensionCode := GeneralLedgerSetup."Global Dimension 1 Code";
2:
DimensionCode := GeneralLedgerSetup."Global Dimension 2 Code";
end;
LibraryDimension.CreateDimensionValue(DimensionValue[1], DimensionCode);
LibraryDimension.CreateDimensionValue(DimensionValue[2], DimensionCode);

LibraryERM.CreateGLAccount(GLAccount);
GLAccount.Validate("Default Deferral Template Code", CreateEqual5Periods());
GLAccount.Modify(true);
CreateGeneralJournalBatch(GenJournalBatch);
UpdateSourceCodeInGenJournalTemplate(GenJournalBatch);
CreateAndPostGenJournalLineWithDeferralAndGlobalDimension(
GenJournalLine[1], GenJournalBatch, GLAccount."No.", GlobalDimensionNo, DimensionValue[1].Code);
CreateAndPostGenJournalLineWithDeferralAndGlobalDimension(
GenJournalLine[2], GenJournalBatch, GLAccount."No.", GlobalDimensionNo, DimensionValue[2].Code);

// [WHEN] Run Deferral Summary - G/L filtered by the first dimension value
GLAccount.SetRecFilter();
case GlobalDimensionNo of
1:
GLAccount.SetRange("Global Dimension 1 Filter", DimensionValue[1].Code);
2:
GLAccount.SetRange("Global Dimension 2 Filter", DimensionValue[1].Code);
end;
PostedDeferralHeader.SetRange("Deferral Doc. Type", PostedDeferralHeader."Deferral Doc. Type"::"G/L");
PostedDeferralHeader.SetRange("Account No.", GLAccount."No.");
Clear(DeferralSummaryGL);
DeferralSummaryGL.SetTableView(GLAccount);
DeferralSummaryGL.SetTableView(PostedDeferralHeader);
DeferralSummaryGL.Run();

// [THEN] The report includes the matching deferral and excludes the other deferral
LibraryReportDataset.LoadDataSetFile();
LibraryReportDataset.AssertElementWithValueExists('GenJnlDocNo', GenJournalLine[1]."Document No.");
LibraryReportDataset.AssertElementWithValueNotExist('GenJnlDocNo', GenJournalLine[2]."Document No.");
end;

local procedure CreateAndPostGenJournalLineWithDeferralAndGlobalDimension(var GenJournalLine: Record "Gen. Journal Line"; GenJournalBatch: Record "Gen. Journal Batch"; GLAccountNo: Code[20]; GlobalDimensionNo: Integer; DimensionValueCode: Code[20])
begin
CreateGenJournalLine(
GenJournalLine, GenJournalBatch."Journal Template Name", GenJournalBatch.Name,
GenJournalLine."Document Type"::" ", GenJournalLine."Account Type"::"G/L Account", GLAccountNo,
GenJournalBatch."Bal. Account Type", GenJournalBatch."Bal. Account No.", LibraryRandom.RandDec(1000, 2));
case GlobalDimensionNo of
1:
GenJournalLine.Validate("Shortcut Dimension 1 Code", DimensionValueCode);
2:
GenJournalLine.Validate("Shortcut Dimension 2 Code", DimensionValueCode);
end;
GenJournalLine.Validate("Deferral Code");
GenJournalLine.Modify(true);
Commit();

LibraryERM.PostGeneralJnlLine(GenJournalLine);
end;

[ModalPageHandler]
[Scope('OnPrem')]
procedure GeneralJournalTemplateHandler(var GeneralJournalTemplateHandler: TestPage "General Journal Template List")
Expand Down Expand Up @@ -2939,4 +3030,4 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
procedure DocumentNoIsBlankMessageHandler(Message: Text[1024])
begin
end;
}
}
93 changes: 92 additions & 1 deletion src/Layers/FR/Tests/ERM/TestREDSetupGenJnl.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
LibrarySetupStorage: Codeunit "Library - Setup Storage";
LibraryTimeSheet: Codeunit "Library - Time Sheet";
LibraryJournals: Codeunit "Library - Journals";
LibraryDimension: Codeunit "Library - Dimension";
DeferralUtilities: Codeunit "Deferral Utilities";
CalcMethod: Enum "Deferral Calculation Method";
DeferralDocType: Option Purchase,Sales,"G/L";
Expand Down Expand Up @@ -2263,6 +2264,22 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
VerifyDeferralSchedule("Deferral Document Type"::Purchase, PurchaseLine."Document Type".AsInteger(), PurchaseLine."Document No.", PurchaseLine."Line No.");
end;

[Test]
[HandlerFunctions('GLDeferralSummaryReportHandler')]
procedure GLDeferralSummaryReportFiltersByGlobalDimension1()
begin
// [SCENARIO 647585] Deferral Summary - G/L respects the Global Dimension 1 filter
VerifyGLDeferralSummaryReportFiltersByGlobalDimension(1);
end;

[Test]
[HandlerFunctions('GLDeferralSummaryReportHandler')]
procedure GLDeferralSummaryReportFiltersByGlobalDimension2()
begin
// [SCENARIO 647585] Deferral Summary - G/L respects the Global Dimension 2 filter
VerifyGLDeferralSummaryReportFiltersByGlobalDimension(2);
end;

local procedure Initialize()
var
AccountingPeriod: Record "Accounting Period";
Expand Down Expand Up @@ -2884,6 +2901,80 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
Assert.RecordIsEmpty(DeferralLine);
end;

local procedure VerifyGLDeferralSummaryReportFiltersByGlobalDimension(GlobalDimensionNo: Integer)
var
DimensionValue: array[2] of Record "Dimension Value";
GeneralLedgerSetup: Record "General Ledger Setup";
GenJournalBatch: Record "Gen. Journal Batch";
GenJournalLine: array[2] of Record "Gen. Journal Line";
GLAccount: Record "G/L Account";
PostedDeferralHeader: Record "Posted Deferral Header";
DeferralSummaryGL: Report "Deferral Summary - G/L";
DimensionCode: Code[20];
begin
Initialize();

// [GIVEN] Two posted deferrals with different values for the selected global dimension
GeneralLedgerSetup.Get();
case GlobalDimensionNo of
1:
DimensionCode := GeneralLedgerSetup."Global Dimension 1 Code";
2:
DimensionCode := GeneralLedgerSetup."Global Dimension 2 Code";
end;
LibraryDimension.CreateDimensionValue(DimensionValue[1], DimensionCode);
LibraryDimension.CreateDimensionValue(DimensionValue[2], DimensionCode);

LibraryERM.CreateGLAccount(GLAccount);
GLAccount.Validate("Default Deferral Template Code", CreateEqual5Periods());
GLAccount.Modify(true);
CreateGeneralJournalBatch(GenJournalBatch);
UpdateSourceCodeInGenJournalTemplate(GenJournalBatch);
CreateAndPostGenJournalLineWithDeferralAndGlobalDimension(
GenJournalLine[1], GenJournalBatch, GLAccount."No.", GlobalDimensionNo, DimensionValue[1].Code);
CreateAndPostGenJournalLineWithDeferralAndGlobalDimension(
GenJournalLine[2], GenJournalBatch, GLAccount."No.", GlobalDimensionNo, DimensionValue[2].Code);

// [WHEN] Run Deferral Summary - G/L filtered by the first dimension value
GLAccount.SetRecFilter();
case GlobalDimensionNo of
1:
GLAccount.SetRange("Global Dimension 1 Filter", DimensionValue[1].Code);
2:
GLAccount.SetRange("Global Dimension 2 Filter", DimensionValue[1].Code);
end;
PostedDeferralHeader.SetRange("Deferral Doc. Type", PostedDeferralHeader."Deferral Doc. Type"::"G/L");
PostedDeferralHeader.SetRange("Account No.", GLAccount."No.");
Clear(DeferralSummaryGL);
DeferralSummaryGL.SetTableView(GLAccount);
DeferralSummaryGL.SetTableView(PostedDeferralHeader);
DeferralSummaryGL.Run();

// [THEN] The report includes the matching deferral and excludes the other deferral
LibraryReportDataset.LoadDataSetFile();
LibraryReportDataset.AssertElementWithValueExists('GenJnlDocNo', GenJournalLine[1]."Document No.");
LibraryReportDataset.AssertElementWithValueNotExist('GenJnlDocNo', GenJournalLine[2]."Document No.");
end;

local procedure CreateAndPostGenJournalLineWithDeferralAndGlobalDimension(var GenJournalLine: Record "Gen. Journal Line"; GenJournalBatch: Record "Gen. Journal Batch"; GLAccountNo: Code[20]; GlobalDimensionNo: Integer; DimensionValueCode: Code[20])
begin
CreateGenJournalLine(
GenJournalLine, GenJournalBatch."Journal Template Name", GenJournalBatch.Name,
GenJournalLine."Document Type"::" ", GenJournalLine."Account Type"::"G/L Account", GLAccountNo,
GenJournalBatch."Bal. Account Type", GenJournalBatch."Bal. Account No.", LibraryRandom.RandDec(1000, 2));
case GlobalDimensionNo of
1:
GenJournalLine.Validate("Shortcut Dimension 1 Code", DimensionValueCode);
2:
GenJournalLine.Validate("Shortcut Dimension 2 Code", DimensionValueCode);
end;
GenJournalLine.Validate("Deferral Code");
GenJournalLine.Modify(true);
Commit();

LibraryERM.PostGeneralJnlLine(GenJournalLine);
end;

[ModalPageHandler]
[Scope('OnPrem')]
procedure GeneralJournalTemplateHandler(var GeneralJournalTemplateHandler: TestPage "General Journal Template List")
Expand Down Expand Up @@ -2939,4 +3030,4 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
procedure DocumentNoIsBlankMessageHandler(Message: Text[1024])
begin
end;
}
}
93 changes: 92 additions & 1 deletion src/Layers/GB/Tests/ERM/TestREDSetupGenJnl.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
LibrarySetupStorage: Codeunit "Library - Setup Storage";
LibraryTimeSheet: Codeunit "Library - Time Sheet";
LibraryJournals: Codeunit "Library - Journals";
LibraryDimension: Codeunit "Library - Dimension";
DeferralUtilities: Codeunit "Deferral Utilities";
CalcMethod: Enum "Deferral Calculation Method";
DeferralDocType: Option Purchase,Sales,"G/L";
Expand Down Expand Up @@ -2325,6 +2326,22 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
VerifyDeferralSchedule("Deferral Document Type"::Purchase, PurchaseLine."Document Type".AsInteger(), PurchaseLine."Document No.", PurchaseLine."Line No.");
end;

[Test]
[HandlerFunctions('GLDeferralSummaryReportHandler')]
procedure GLDeferralSummaryReportFiltersByGlobalDimension1()
begin
// [SCENARIO 647585] Deferral Summary - G/L respects the Global Dimension 1 filter
VerifyGLDeferralSummaryReportFiltersByGlobalDimension(1);
end;

[Test]
[HandlerFunctions('GLDeferralSummaryReportHandler')]
procedure GLDeferralSummaryReportFiltersByGlobalDimension2()
begin
// [SCENARIO 647585] Deferral Summary - G/L respects the Global Dimension 2 filter
VerifyGLDeferralSummaryReportFiltersByGlobalDimension(2);
end;

local procedure Initialize()
var
AccountingPeriod: Record "Accounting Period";
Expand Down Expand Up @@ -2946,6 +2963,80 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
Assert.RecordIsEmpty(DeferralLine);
end;

local procedure VerifyGLDeferralSummaryReportFiltersByGlobalDimension(GlobalDimensionNo: Integer)
var
DimensionValue: array[2] of Record "Dimension Value";
GeneralLedgerSetup: Record "General Ledger Setup";
GenJournalBatch: Record "Gen. Journal Batch";
GenJournalLine: array[2] of Record "Gen. Journal Line";
GLAccount: Record "G/L Account";
PostedDeferralHeader: Record "Posted Deferral Header";
DeferralSummaryGL: Report "Deferral Summary - G/L";
DimensionCode: Code[20];
begin
Initialize();

// [GIVEN] Two posted deferrals with different values for the selected global dimension
GeneralLedgerSetup.Get();
case GlobalDimensionNo of
1:
DimensionCode := GeneralLedgerSetup."Global Dimension 1 Code";
2:
DimensionCode := GeneralLedgerSetup."Global Dimension 2 Code";
end;
LibraryDimension.CreateDimensionValue(DimensionValue[1], DimensionCode);
LibraryDimension.CreateDimensionValue(DimensionValue[2], DimensionCode);

LibraryERM.CreateGLAccount(GLAccount);
GLAccount.Validate("Default Deferral Template Code", CreateEqual5Periods());
GLAccount.Modify(true);
CreateGeneralJournalBatch(GenJournalBatch);
UpdateSourceCodeInGenJournalTemplate(GenJournalBatch);
CreateAndPostGenJournalLineWithDeferralAndGlobalDimension(
GenJournalLine[1], GenJournalBatch, GLAccount."No.", GlobalDimensionNo, DimensionValue[1].Code);
CreateAndPostGenJournalLineWithDeferralAndGlobalDimension(
GenJournalLine[2], GenJournalBatch, GLAccount."No.", GlobalDimensionNo, DimensionValue[2].Code);

// [WHEN] Run Deferral Summary - G/L filtered by the first dimension value
GLAccount.SetRecFilter();
case GlobalDimensionNo of
1:
GLAccount.SetRange("Global Dimension 1 Filter", DimensionValue[1].Code);
2:
GLAccount.SetRange("Global Dimension 2 Filter", DimensionValue[1].Code);
end;
PostedDeferralHeader.SetRange("Deferral Doc. Type", PostedDeferralHeader."Deferral Doc. Type"::"G/L");
PostedDeferralHeader.SetRange("Account No.", GLAccount."No.");
Clear(DeferralSummaryGL);
DeferralSummaryGL.SetTableView(GLAccount);
DeferralSummaryGL.SetTableView(PostedDeferralHeader);
DeferralSummaryGL.Run();

// [THEN] The report includes the matching deferral and excludes the other deferral
LibraryReportDataset.LoadDataSetFile();
LibraryReportDataset.AssertElementWithValueExists('GenJnlDocNo', GenJournalLine[1]."Document No.");
LibraryReportDataset.AssertElementWithValueNotExist('GenJnlDocNo', GenJournalLine[2]."Document No.");
end;

local procedure CreateAndPostGenJournalLineWithDeferralAndGlobalDimension(var GenJournalLine: Record "Gen. Journal Line"; GenJournalBatch: Record "Gen. Journal Batch"; GLAccountNo: Code[20]; GlobalDimensionNo: Integer; DimensionValueCode: Code[20])
begin
CreateGenJournalLine(
GenJournalLine, GenJournalBatch."Journal Template Name", GenJournalBatch.Name,
GenJournalLine."Document Type"::" ", GenJournalLine."Account Type"::"G/L Account", GLAccountNo,
GenJournalBatch."Bal. Account Type", GenJournalBatch."Bal. Account No.", LibraryRandom.RandDec(1000, 2));
case GlobalDimensionNo of
1:
GenJournalLine.Validate("Shortcut Dimension 1 Code", DimensionValueCode);
2:
GenJournalLine.Validate("Shortcut Dimension 2 Code", DimensionValueCode);
end;
GenJournalLine.Validate("Deferral Code");
GenJournalLine.Modify(true);
Commit();

LibraryERM.PostGeneralJnlLine(GenJournalLine);
end;

[ModalPageHandler]
[Scope('OnPrem')]
procedure GeneralJournalTemplateHandler(var GeneralJournalTemplateHandler: TestPage "General Journal Template List")
Expand Down Expand Up @@ -3001,4 +3092,4 @@ codeunit 134803 "Test RED Setup Gen. Jnl."
procedure DocumentNoIsBlankMessageHandler(Message: Text[1024])
begin
end;
}
}
Loading
Loading