[29.x]-[WHT] Inconsistency with the Payments

[ViditGupta1277]

Fixes AB#648516

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

The change adds an explicit error when WHT payment posting cannot find a general journal template of type Purchases. The changed branch is the same branch where the WHT posting buffer is skipped today, so the payment still cannot complete and the missing WHT G/L posting is not created.

Problem-solution fit

Fit: Partial

The reported scenario is a partial vendor payment with gross-base WHT where posting should create the WHT entries and keep G/L in balance. The change prevents the silent buffer skip, but it does so by failing the posting instead of completing the expected payment and validating the WHT amounts.

Suggestions

S1 (🔴 High): Setup error replaces the payment fix
The reported payment should post and create the WHT G/L entry. This branch now raises a setup error when no Purchases template is found, so it still stops the payment instead of creating the missing posting buffer. Handle this case in the WHT posting-buffer path, or prove with a regression test that the setup is invalid.

S2 (🔴 High): Missing regression test for WHT payment posting
This is WHT payment posting, so the exact changed path needs a test. Add a partial vendor payment test with gross-base WHT that reaches this branch, and assert the payment posts, the WHT G/L entry exists, and the remaining/unrealized WHT amounts have the expected signs.

Risk assessment and necessity

Risk: The touched code is in WithholdingTaxMgmt.Codeunit.al inside vendor payment realization. A wrong change here can leave WHT entries and G/L posting out of sync, especially for partial payments and journal-template setups that do not match the assumed purchase template.

Necessity: A fix is required because the scenario affects payment posting and G/L balance. The scope should stay narrow, but it must complete the posting path rather than only replacing the balance error with a setup error.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10869 round=1 by=alexei-dobriansky at=2026-09-01T07:16:24.7740354Z lastSha=ffd52e3ac4ba4cf2158f5e5def82de40941aa7c1 reviewKey=a8249558ebe81d2e63a662de491e763d8c653b619c20bfdf9eb3c899cca5848c suggestions=S1@2bf11594,S2@76a223a7

[github-actions]

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

---

🔄 How to trigger a new status check:

1. 📤 Push a new commit to the PR branch, or
2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.