Skip to content

[Master]-Bug 645041: Expense Agent - Rename Enable approval workflow caption and tooltip - #10825

Open
v-rohangarg20 wants to merge 1 commit into
mainfrom
bugs/645041-rename-approval-workflow-caption
Open

[Master]-Bug 645041: Expense Agent - Rename Enable approval workflow caption and tooltip#10825
v-rohangarg20 wants to merge 1 commit into
mainfrom
bugs/645041-rename-approval-workflow-caption

Conversation

@v-rohangarg20

@v-rohangarg20 v-rohangarg20 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#645041

Issue: On the Expense Agent Setup page the "Enable approval workflow" toggle had a generic caption and tooltip that did not make clear it switches expense reports to the traditional approval workflow instead of the Expense Agent approval experience, and it sat at standard importance among unrelated controls.

Cause: The field was labelled "Enable approval workflow" with a tooltip that only stated approval workflow is enabled, and used default Importance, so its purpose relative to the Expense Agent experience was ambiguous on the page.

Solution: Renamed the caption to "Use traditional approval workflow" and updated the tooltip to "Specifies whether expense reports use the traditional approval workflow instead of the Expense Agent approval experience." Set this field and the related Default Approver field to Importance = Additional so they surface only when relevant, per review feedback on the work item.

@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area labels Aug 31, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Aug 31, 2026
@v-rohangarg20
v-rohangarg20 marked this pull request as ready for review September 2, 2026 04:24
@v-rohangarg20
v-rohangarg20 requested a review from a team September 2, 2026 04:24
@v-rohangarg20
v-rohangarg20 requested a review from a team as a code owner September 2, 2026 04:24
@v-rohangarg20 v-rohangarg20 changed the title Workitem Bug 645041: [main] Expense Agent - Rename Enable approval workflow caption and tooltip [Master] Expense Agent - Rename Enable approval workflow caption and tooltip Sep 2, 2026
@v-rohangarg20 v-rohangarg20 changed the title [Master] Expense Agent - Rename Enable approval workflow caption and tooltip [Master]-Expense Agent - Rename Enable approval workflow caption and tooltip Sep 2, 2026
@v-rohangarg20 v-rohangarg20 changed the title [Master]-Expense Agent - Rename Enable approval workflow caption and tooltip [Master]-Bug 645041: Expense Agent - Rename Enable approval workflow caption and tooltip Sep 2, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change renames the setup toggle to "Use traditional approval workflow", updates its tooltip to explain the choice against the Expense Agent approval experience, and moves it and Default Approver to Additional importance on the setup page.

The diff matches the field it needs to clarify. The page control is bound to the same table field, so the caption and tooltip flow to the setup page, and the existing validation that prevents using the agent and traditional approval workflow together is unchanged. The Importance changes affect only page layout metadata and do not change approval or posting behavior.

Problem-solution fit

Fit: Strong

The bug says the setup field text was unclear about which approval experience is used. The new caption and tooltip state that the enabled state means traditional approval workflow, and the page metadata change keeps the related fields less prominent without changing their behavior.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: The regression surface is limited to the Expense Agent Setup page and table field metadata. The change does not modify posting, approval validation, public APIs, event signatures, table schema, or upgrade data; the main UI risk is that the two fields now sit under Additional importance.

Necessity: The change is needed because the old label could read as enabling the Expense Agent approval flow, while the field actually enables the traditional approval workflow and conflicts with Enable Agent. The scope is right for that problem because it only updates the visible wording and page importance.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10825 round=1 by=alexei-dobriansky at=2026-09-02T07:10:52Z lastSha=9c0b66e44e2144106e32581f00f2f8aab2319a3f reviewKey=b48c8804a36d29de0ccada17f819a06b4c946665ffcacba6b5a006ab498eaf1a suggestions=

}
field(DefaultApprover; Rec."Default Approver Name")
{
Importance = Additional;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default approver name is related to web app approval.. and this is where the end user can completely get confused. Maybe we need a separate tab for BC approval scenario. Please seek Toto's opinion.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants