Slice 641293: [Expense Agent] Expense Locations and Per-diem rules in configurationAdded more locations

src/Apps/AT/ExpenseAgent_AT/app/src/ExpenseEventSubscriberAT.Codeunit.al

@@ -13,4 +13,4 @@ codeunit 6914 "Expense Event Subscriber AT"
     ObsoleteReason = 'The AT-specific expense setup has been merged into the base Expense Agent app.';
     ObsoleteTag = '30.0';
 }
-#endif
+#endif

src/Apps/W1/ExpenseAgent/app/src/APIs/ExpAttachBufferHandler.Codeunit.al

@@ -135,7 +135,7 @@ codeunit 6952 "Exp. Attach. Buffer Handler"
         end;
 
         // Split filename into name and extension
-        DocumentAttachment.Validate("File Extension", FileManagement.GetExtension(AttachmentEntityBuffer."File Name"));
+        DocumentAttachment.Validate("File Extension", CopyStr(FileManagement.GetExtension(AttachmentEntityBuffer."File Name"), 1, MaxStrLen(DocumentAttachment."File Extension")));
         DocumentAttachment.Validate("File Name", CopyStr(FileManagement.GetFileNameWithoutExtension(AttachmentEntityBuffer."File Name"), 1, MaxStrLen(DocumentAttachment."File Name")));
 
         BindSubscription(ExpDocAttSubscribers);
@@ -164,7 +164,7 @@ codeunit 6952 "Exp. Attach. Buffer Handler"
         if HasRegisteredField(AttachmentEntityBuffer.FieldNo("File Name"), TempFieldBuffer) then begin
             ExpenseAttachmentMgt.RestrictAttachment(DocumentAttachment);
 
-            DocumentAttachment.Validate("File Extension", FileManagement.GetExtension(AttachmentEntityBuffer."File Name"));
+            DocumentAttachment.Validate("File Extension", CopyStr(FileManagement.GetExtension(AttachmentEntityBuffer."File Name"), 1, MaxStrLen(DocumentAttachment."File Extension")));
             DocumentAttachment.Validate("File Name", CopyStr(FileManagement.GetFileNameWithoutExtension(AttachmentEntityBuffer."File Name"), 1, MaxStrLen(DocumentAttachment."File Name")));
             ModifyRecord := true;
         end;

src/Apps/W1/ExpenseAgent/app/src/Expense/Tables/Expense.Table.al

@@ -334,7 +334,7 @@ table 6900 Expense
                 CreateDimFromDefaultDim(Rec.FieldNo("Billable to Customer"));
             end;
         }
-        field(23; "Expense Location"; Code[30])
+        field(23; "Expense Location"; Code[30]) // NB: Expense Location Code has length 20.
         {
             Caption = 'Expense Location';
             TableRelation = "Expense Location";

src/Apps/W1/ExpenseAgent/app/src/ExpenseReport/Codeunits/CreateExpenseReport.Codeunit.al

@@ -176,7 +176,7 @@ codeunit 6983 "Create Expense Report"
         ExpenseReportLine.Validate("Expense User No.", Expense."Expense User No.");
         ExpenseReportLine.Validate("Expense Category", Expense."Expense Category");
         ExpenseReportLine.Validate("Expense Subcategory Code", Expense."Expense Subcategory");
-        ExpenseReportLine.Validate("Expense Location", CopyStr(Expense."Expense Location", 1, 20));
+        ExpenseReportLine.Validate("Expense Location", CopyStr(Expense."Expense Location", 1, MaxStrLen(ExpenseReportLine."Expense Location")));
         if Expense.Description <> '' then
             ExpenseReportLine.Validate(Description, Expense.Description);
         if ExpenseReportLine."Expense Subcategory Code" <> '' then

src/Apps/W1/ExpenseAgent/app/src/ExpenseReport/Codeunits/ReleaseExpReportDocument.Codeunit.al

@@ -28,6 +28,7 @@ codeunit 6984 "Release Exp. Report Document"
         CannotReleaseDocumentWithNothingToRefundErr: Label 'Cannot release the Expense Report No. %1 because there is nothing to refund for this Line No. %2.', Comment = '%1 - Expense No. , %2 - Line No.';
         PolicyEvaluationNotCurrentErr: Label 'One or more expense lines have a policy evaluation that is not up to date. Re-run policy evaluation and approve again.';
         PolicyEvaluationNotCurrentCodeTok: Label ' (PolicyEvaluationNotCurrent)', Locked = true;
+        ReimbursementErr: Label 'Reimbursement type must be set to a value in expense report %1, line %2 with description %3.', Comment = '%1 - Expense No. , %2 - Line No., %3 - description';
 
     local procedure ReleaseExpenseReport()
     var
@@ -75,7 +76,8 @@ codeunit 6984 "Release Exp. Report Document"
             ExpenseSubCategory.TestField(Inactive, false);
 
         ExpenseReportLine.TestField(Description);
-        ExpenseReportLine.TestField("Reimbursement Type");
+        if ExpenseReportLine."Reimbursement Type" = ExpenseReportLine."Reimbursement Type"::" " then
+            Error(ReimbursementErr, ExpenseReportLine."Expense No.", ExpenseReportLine."Line No.", ExpenseReportLine.Description);
 
         if ExpenseReportLine."Job No." <> '' then
             ExpenseReportLine.TestField("Job Task No.");

src/Apps/W1/ExpenseAgent/app/src/MasterData/Tables/ExpenseRuleCondition.Table.al

@@ -8,8 +8,6 @@ table 6926 "Expense Rule Condition"
 {
     Access = Internal;
     Caption = 'Expense Rule Condition';
-    LookupPageId = "Expense Management Rules";
-    DrillDownPageId = "Expense Management Rules";
     DataClassification = CustomerContent;
     ReplicateData = false;
 

src/Apps/W1/ExpenseAgent/app/src/MasterData/Tables/ExpenseRuleHeader.Table.al

@@ -12,6 +12,7 @@ table 6927 "Expense Rule Header"
     Access = Internal;
     Caption = 'Expense Rule Header';
     DataClassification = CustomerContent;
+    LookupPageId = "Expense Management Rules";
     ReplicateData = false;
 
     fields

src/Apps/W1/ExpenseAgent/app/src/Permissions/AgentUserPermissions/ExpenseAgentObjects.PermissionSet.al

@@ -143,7 +143,6 @@ permissionset 6952 "Expense Agent - Objects"
                   codeunit "Expense Auto Population" = X,
                   codeunit "Expense Capabilities Provider" = X,
                   codeunit "Expense Activity Log Mgt." = X,
-                  codeunit "Expense Projects Builder" = X,
                   codeunit "Exp. Policies To Eval Builder" = X,
                   codeunit "Expense Consumption Handler" = X,
                   codeunit "Expense Currency" = X,
@@ -157,6 +156,7 @@ permissionset 6952 "Expense Agent - Objects"
                   codeunit "Expense Report-Post" = X,
                   codeunit "Expense Preview Post Instance" = X,
                   codeunit "Expense Preview Post Mgt." = X,
+                  codeunit "Expense Projects Builder" = X,
                   codeunit "Expense Report" = X,
                   codeunit "Expense Report Approval Mgmt" = X,
                   codeunit "Expense Report Batch Post Mgt." = X,

src/Apps/W1/ExpenseAgent/app/src/Permissions/ExpenseManagementObjects.PermissionSet.al

@@ -202,6 +202,9 @@ permissionset 6904 "Expense Management - Objects"
         codeunit "Expense Preview Post Instance" = X,
         codeunit "Expense Approval Helper" = X,
         codeunit "Create Expense Agent Setup" = X,
+        codeunit "Create Expense Locations" = X,
+        codeunit "Create Expense Rule Conditions" = X,
+        codeunit "Create Expense Rule Headers" = X,
         codeunit "Create Expense Categories" = X,
         codeunit "Create Expense VAT Rates" = X,
         codeunit "Create Expense GL Account" = X,