Repository navigation
pyproject.toml: Add ruff.lint prefixes to format settings. - #1059
Merged
Merged
Conversation
dpgeorge
reviewed
Nov 13, 2025
Josverl
force-pushed
the
chore_ruff
branch
2 times, most recently
from
November 18, 2025 09:07
adf3020 to
b0a30e5
Compare
Josverl
commented
Nov 18, 2025
| "unix-ffi", | ||
| ] | ||
| line-length = 99 | ||
| target-version = "py38" # enable use of walrus operator |
Contributor
Author
There was a problem hiding this comment.
Bumped to 3.8 to support the walrus operator which is supported and used.
invalid-syntax: Cannot use named assignment expression (`:=`) on Python 3.7 (syntax was added in Python 3.8)
--> micropython/bluetooth/aioble/aioble/peripheral.py:137:20
|
135 | (16, _ADV_TYPE_UUID128_COMPLETE),
136 | ):
137 | if uuids := [bytes(uuid) for uuid in services if len(bytes(uuid)) == uuid_len]:
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
138 | resp_data = _append(adv_data, resp_data, code, b"".join(uuids))
I think this would need the same change on the micropython/micropython repo as well
Member
There was a problem hiding this comment.
I think this would need the same change on the micropython/micropython repo as well
Yes, that's fair enough.
dpgeorge
approved these changes
Nov 18, 2025
Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
Changes are: - Reorganize lint settings to new sections. - Align ignore rules with micropython/micropython repo. - Update to python38 syntax to enable `:=` operator. Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
Member
|
Thanks for updating. |
jakub-vesely
pushed a commit
to jakub-vesely/micropython
that referenced
this pull request
Sep 21, 2026
As per 3ee912a the tests now target Python 3.8 syntax and features, so update the ruff configuration to match. Changes in this commit: - Update to Python 3.8 syntax. - Ignore import not at top of module warnings. - Exclude common SDK folders. - Exclude cpydiff test with intentional error. Also see: micropython/micropython-lib#1059 Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff ruff 0.11.6 is warming about the settings.