Improve feature separation#130
Open
JKingweb wants to merge 9 commits into
Open
Conversation
… matching The Rust parser unfairly fails the test without this change
I have no idea why I included these cases in the first place
This helps Go and Rust to pass Unfortunately it's virtually impossible to avoid implied names entirely in these cases
Not all blank implied names can be avoided, unfortunately
The segregated cases were also modified to smooth out implied-name interactions
At least js-shiv fails this test due to differences in nested microformat handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the original goals of the "unit" tests was to, as the name implies, test features in isolation as much as possible. Looking through the test results of various parsers I've identified several places where the tests fall a bit short of what's possible.
These changes don't modify the substance of the tests, but they do help the Rust parser to pass two more tests, and the Go parser to pass one additional test. Individual commit messages provide a few details on the changes.