Skip to content

fix: use root-relative path for quick start and documentation links - #620

Merged
yada merged 1 commit into
microcks:masterfrom
ish-g09:fix-relative-doc-links
Oct 20, 2026
Merged

yada merged 1 commit into
microcks:masterfrom
ish-g09:fix-relative-doc-links

Conversation

@ish-g09

@ish-g09 ish-g09 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Description

  • Fixed the 14 recurring broken link errors on paginated pages reported in the weekly link check.
  • In config/_default/menus.en.toml, the footer_left Quick Start link was configured as a relative path (./documentation/tutorials/getting-started/).
  • Because Hugo processes it through relLangURL in the footer partial, the ./ prefix caused the browser and link checker to resolve the link relative to /page/X/ (e.g. /page/2/, /page/3/, up to /page/15/), generating non-existent paths like https://microcks.io/page/2/documentation/tutorials/getting-started/ (404).
  • Updated the link to be root-relative (/documentation/tutorials/getting-started/) so it stays consistent across all pages and pagination depths.
  • Also updated the hero button in content/_index.md from ./documentation/tutorials/getting-started/ to /documentation/tutorials/getting-started/.

Related issue(s)

Fixes #584

Testing

  • Ran Hugo locally and navigated to http://localhost:1313/page/2/.
  • Verified that the Quick Start footer link points directly to http://localhost:1313/documentation/tutorials/getting-started/ rather than appending to /page/2/.
  • Confirmed the page opens as expected with no 404.

Signed-off-by: ish-g09 <ig.valiente09@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 20, 2026 20:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

👋 @ish-g09

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly.

Hope you have a great time there!

@yada yada added component/rendering Relates to rendering engine and dependencies component/documentation labels Oct 20, 2026

@yada yada left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification ✅

I built the site locally and ran the same internal link check as the weekly workflow (lychee --offline --include-fragments=anchor-only --index-files index.html --root-dir <public>) on the paginated pages, once on master and once with this PR applied.

Setup: Hugo 0.123.0 extended (the version pinned in netlify.toml), lychee 0.24.2.

Footer "Quick Start" link on /page/2/

Rendered HTML
master href=./documentation/tutorials/getting-started/
This PR href=/documentation/tutorials/getting-started/

lychee on public/page/**/*.html

Result
master 14 errors, for example /page/9/documentation/tutorials/getting-started (File not found), on pages 2 to 15
This PR 0 errors (1821 links total, 1050 OK)

The 14 errors on master match the 14 reported in #584. None remain with this change.

Root cause: the footer URL ./documentation/... goes through relLangURL, which leaves the ./ prefix untouched. On /page/N/ it therefore resolved to /page/N/documentation/.... A root-relative path resolves the same way from every page.

LGTM, safe to merge. Fixes #584.

@yada
yada merged commit 05bbc5b into microcks:master Oct 20, 2026
9 checks passed
@github-actions

Copy link
Copy Markdown

🎉 @ish-g09

You are now a Microcks community contributor! 💖

Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Kudos and please keep going, we need you 🙌

@ish-g09
ish-g09 deleted the fix-relative-doc-links branch October 20, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/documentation component/rendering Relates to rendering engine and dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External Link Check Report

3 participants