Repository navigation
Conversation
domain_is_in? checks each MX host in an any? loop. For a short host name with one dot (for example ordinary.example) that is not on the list, it used `return false`. In Ruby, `return` inside a block stops the whole method, so the other MX hosts were never checked. Use `next false` so the loop goes on to the next host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disposable?can return the wrong answer when a domain has more than one MX record.The problem
domain_is_in?checks each MX host in a loop. Some MX hosts have a short name with one dot, for exampleordinary.example. If that host is not on the list, the method usesreturn false. In Ruby,returninside a block stops the whole method. So the method does not check the other MX hosts.How to see it
A domain has these MX records, in this order:
ordinary.exampleemailfake.com(this is on the disposable list)disposable?returnsfalse. If you swap the order, it returnstrue.The fix
Change
return falsetonext false. Now the loop goes on to the next host.I added two specs, one for each order. The first spec fails without the fix.