Encode spaces as %20 in presigned query strings - #85
Open
brennanbutler01 wants to merge 1 commit into
Open
brennanbutler01 wants to merge 1 commit into
brennanbutler01 wants to merge 1 commit into
Conversation
Normalize form-encoded spaces after adding signature and session-token parameters. Preserve literal plus signs and signature inputs. Add browser regressions and regenerate the tracked JavaScript distributions. Prepared with OpenAI Codex assistance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query signing calculates a canonical query with
%20, butURLSearchParamsserializes spaces as+in the returned URL. Normalize spaces after adding the signature and any appended session token, preserving literal plus signs, decoded values, and the existing signature.Closes #83.
Adds browser coverage for spaces, literal plus signs, encoded-space strings, Unicode, empty values, pre-encoded input, and both session-token modes. Includes the four regenerated JavaScript distributions, following existing upstream changes. Unrelated declaration-output differences from the installed TypeScript version are excluded.
Validation on Node 24 and local Chrome:
npm run lint,npm run build, andnpm run test-nodepass.Hosted storage services were not contacted, and
npm run integrationwas not run. The provider rejection in #83 is the reporter's evidence; this change verifies encoding and signature preservation locally.Prepared with OpenAI Codex assistance.