Repository navigation
Infer the entity class from loadRevision(), loadRevisionUnchanged() and loadMultipleRevisions() - #1099
Open
mstrelan wants to merge 1 commit into
Open
Infer the entity class from loadRevision(), loadRevisionUnchanged() and loadMultipleRevisions()#1099mstrelan wants to merge 1 commit into
mstrelan wants to merge 1 commit into
Conversation
…nd loadMultipleRevisions()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntityStorageDynamicReturnTypeExtensionalready narrowsload(),loadUnchanged(),loadMultiple(),loadByProperties()andcreate()to the entity class when the storage's entity type is known. The revision loaders were left out, so this still reports an undefined method:This adds
loadRevision(),loadRevisionUnchanged()andloadMultipleRevisions()to the supported methods.The new methods are only narrowed when the entity type ID is known (an
EntityStorageType). For a storage that is only typed asRevisionableStorageInterface,EntityDataRepository::resolveFromStorage()returns the first mapped entity type whose storage matches, such asblock_content, which would give the wrong class. In that case the declared return type is kept. The existing methods are unchanged.Measured against Drupal core
mainwithout its baseline, over the 147 files that call these methods: 28 errors removed (22 baseline entries), none added.