Repository navigation
Add a regression test for #pre_render callbacks on a union of classes - #1094
Merged
Merged
Conversation
[$class, 'method'] where $class is Checkboxes::class|Radios::class is callable when every class has the method, and not callable when only one does. Both already work on main. Fixes #457. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #457.
The issue reported
RenderCallbackRuleflagging a callback whose class is picked at runtime:This no longer happens on
main.$classis still'…\Checkboxes'|'…\Radios', but the callable check now passes when the method exists on every class in the union.preRenderCompositeFormElement()comes fromCompositeFormElementTrait, which both classes use.This adds the test case the issue asked for, so it stays fixed:
[$class, $type] = ... ? [...] : [...]with the method on both classes: not reported.$class = ... ? Checkboxes::class : Radios::classwith the method on both classes: not reported.processCheckboxes(), which onlyCheckboxeshas: reported as not callable, because theRadioscase would fail.No code changes.
RenderCallbackRuleTestpasses.🤖 Generated with Claude Code