refactor: centralize run status and simplify runtime ownership - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Run status had several secondary write paths and failure windows, while Runtime Host lifecycle state still exposed lower-level mutation APIs. That made Run/Conversation projection convergence and worker cleanup harder to reason about.
What
The original refactor remains intact, including the registered Runtime Host execution chain. This follow-up adds thirteen isolated commits:
fix(runtime): keep dependency sync build-freerefactor(run): route launch failures through status ownerRunStatusServicerefactor(run): converge stale cancellation centrallyfix(run): release failed launch claimstest(run): guard status ownership boundariesRunStatusServicefix(run): reconcile stale conversation projectionsrefactor(runtime): encapsulate worker pool lifecycleRuntimeHostcannot bypass registry eviction with rawWorkerPool.removechore: align run refactor quality gatesfix(ci): satisfy server lint gatesfix(test): validate runtime plugin identifiersfix(run): guard conversation projection ownershipConversation.activeRunIdcompare-and-set ownership so an older Run cannot overwrite a newer Run's Conversation projection during steeringfix(test): align conversation projection mockfix(test): satisfy run status lintThe registered execution/tunnel chain is preserved.
Validation
GitHub Actions Server workflow #44 passed: