Skip to content

fix(skills): propose default stops at open PR; merge gated behind --ship - #98

Merged
utx0 merged 31 commits into
mainfrom
metta/fix-metta-propose-runs-entire-lifecycle-through-finalize
Aug 22, 2026
Merged

fix(skills): propose default stops at open PR; merge gated behind --ship#98
utx0 merged 31 commits into
mainfrom
metta/fix-metta-propose-runs-entire-lifecycle-through-finalize

Conversation

@utx0

@utx0 utx0 commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

/metta-propose's default terminal state is now PR-open: the skill runs the full pipeline (discovery → planning → implementation → verification → finalize → push → gh pr create) then stops and reports the PR URL. It no longer runs gh pr merge by default. Merging is an explicit opt-in via --ship (skill alias) or --stop-after ship, wired through the existing propose-stop-after machinery. /metta-auto and /metta-fix-issues keep run-to-merge behavior unchanged.

Resolves issue metta-propose-runs-the-entire-lifecycle-through-finalize-and (zeus PR #28, metta PR #85 incidents).

Changes

  • Both metta-propose SKILL.md copies (byte-identical): --ship alias with misparse constraints + mandatory announcement, ship-gated Step 8 (checks-watch/merge/cleanup only when stop_after = ship), exhaustive no-merge default, quick-reroute carries the PR-open default over, Critical section retitled Critical: verify, finalize, and open the PR
  • src/cli/commands/propose.ts: ship accepted as a stop-after sentinel (bypasses buildOrder validation); error lists and help name ship
  • src/cli/commands/refresh.ts + CLAUDE.md: lifecycle bullet states the PR-open default (generator and doc in lockstep)
  • New tests/skill-propose-ship-gate.test.ts (10 grep-assert tests, mutation-verified); tests/cli-propose-stop-after.test.ts extended for ship
  • Spec delta merged into the propose-stop-after capability

Verification

  • Full suite: 134/134 files, 2709 passed, 0 failed; tsc --noEmit and lint clean
  • Reviews: 2 rounds × 3 reviewers — final verdicts PASS / PASS_WITH_WARNINGS (residual warnings all fail safe: worst case stops at open PR)
  • Spec coverage: all 8 delta requirements verified (22/23 scenarios covered)

🤖 Generated with Claude Code

https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK

ryder and others added 30 commits August 22, 2026 08:57
…esize research

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK
…d CLAUDE.md

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK
…mentation summary

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK
…w round 1

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK
…s in propose

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK
…w round 2

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK
…ication results

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK
@utx0
utx0 merged commit 310ea57 into main Aug 22, 2026
2 checks passed
@utx0
utx0 deleted the metta/fix-metta-propose-runs-entire-lifecycle-through-finalize branch August 22, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant