feat: enforce agent-executed UAT run with PR-attached results before ship hand-back - #100
Merged
utx0 merged 44 commits intoAug 23, 2026
Conversation
…ord instruction emission
…ord instruction emission
…ord instruction emission
…ord instruction emission
…arch config-get toggle approach
…arch finalize-json toggle approach
…arch skill gate block design
…ord instruction emission
…install-scaffold default-on for enforce_on_ship
…ord instruction emission
…ord instruction emission
…fold explicit uat.enforce_on_ship in install config Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK
…uat.enforce_on_ship schema field
… uat override into scaffolded config block in finalize CLI test
…ace uatEnforceOnShip on FinalizeResult
…UAT gate to metta-auto skill pair
…UAT gate to metta-quick skill pair
…UAT gate to metta-propose skill pair
added 14 commits
August 23, 2026 17:05
…UAT gate to metta-fix-issues skill pair
…UAT gate to metta-ship skill pair
…UAT gate to metta-fix-gap skill pair
…gelog entry for ship-path UAT gate
…skill-uat-ship-gate grep-assert suite
… uatEnforceOnShip from finalize CLI
…ementation summary
…lete implementation
…e verification results
…lete verification
…hive and finalize
…nerated docs from finalize
utx0
deleted the
metta/enforce-agent-executed-uat-run-results-attached-pr-before
branch
August 23, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every ship-path skill (metta-ship, metta-propose, metta-quick, metta-auto, metta-fix-issues, metta-fix-gap) now runs the archived UAT.md through the
metta-uat-runnersubagent betweenmetta finalizeandgit push, attaches a## UAT resultssummary to the PR (body at create, comment on an existing PR), and treats any failed step as a hand-back blocker — the PR stays open, unmerged, and flagged. Manual-acceptance steps skip and never block; machine-verified steps pass automatically.uat.enforce_on_ship(default on — Zod.default(true), omitted-key default, and explicitenforce_on_ship: truein themetta installscaffold; opting out is the explicit action)metta finalize --jsonnow emitsuatEnforceOnShipbesideuatPath; abort/dry-run paths hardcodetrue(fail-toward-enforce); absent field in older payloads is treated astrueAgentin allowed-tools plus an already-finalized branch with a reuse short-circuit; fix-issues/fix-gap tie issue/gap removal to a passed gate; propose distinguishes "PR open, flagged — UAT failed" from the ready hand-backtests/skill-uat-ship-gate.test.ts(39 grep-assert ordering/identity assertions) plus extensions to config-loader, cli-install, finalizer, and cli-finalize suitesfinalize-ship(8 ADDED, 1 MODIFIED); guard hooks, metta-uat-runner agent, /metta-uat skill, and uat-generator deliberately untouchedVerification: 135 test files, 2756 passed, 2 skipped, 0 failed;
tsc --noEmit, lint, and build clean. Review: correctness PASS_WITH_WARNINGS (minor), security PASS_WITH_WARNINGS (minor), quality PASS — no critical/major findings. Spec traceability: 24/24 delta scenarios evidenced.UAT results
Result: 8 pass / 0 fail / 35 skip (of 43 steps) — PASS
Run: 2026-08-23 · record committed as
docs(enforce-agent-executed-uat-run-results-attached-pr-before): UAT run record(72fa3e0) ·spec/archive/2026-08-23-enforce-agent-executed-uat-run-results-attached-pr-before/UAT.mdSkipped — needs manual acceptance
The 35 skipped steps require live ship-path skill executions, real PR operations (
gh pr create/comment/merge), live guard-hook sessions, ormetta finalize/metta installinvocations forbidden to the runner. Static ordering and identity guarantees for those flows are covered by the passingskill-uat-ship-gatesuite (39/39). Full per-step reasons are in the committed run record.Passed steps include: schema default-on (omitted key →
enforce_on_ship: true), strict rejection of unknown/non-boolean uat config, metta-shipAgentallowed-tools in both byte-identical copies, single-runner-path confirmation, skip-not-fail semantics, and the full test-suite gate.🤖 Generated with Claude Code
https://claude.ai/code/session_01AA8wwFpob25iYZFCBBEtKK