Fix inconsistencies found by Ai, update deps#127
Merged
Merged
Conversation
majst01
commented
May 23, 2026
Comment on lines
-31
to
-68
|
|
||
| // MachineProvisioningEvent contains details about an event. | ||
| message MachineProvisioningEvent { | ||
| // Time the event occurred at | ||
| google.protobuf.Timestamp time = 1; | ||
| // Event that occurred | ||
| ProvisioningEventType event = 2 [(buf.validate.field).enum.defined_only = true]; | ||
| // Message describes the event in more detail | ||
| string message = 3; | ||
| } | ||
|
|
||
| // ProvisioningEventType is a short description of a machine event. | ||
| enum ProvisioningEventType { | ||
| // PROVISIONING_EVENT_TYPE_UNSPECIFIED is unspecified | ||
| PROVISIONING_EVENT_TYPE_UNSPECIFIED = 0; | ||
| // PROVISIONING_EVENT_TYPE_ALIVE means the machine has reported itself to the API not long ago | ||
| PROVISIONING_EVENT_TYPE_ALIVE = 1 [(metalstack.api.v2.enum_string_value) = "Alive"]; | ||
| // PROVISIONING_EVENT_TYPE_CRASHED means an irregularity in the machine's lifecycle | ||
| PROVISIONING_EVENT_TYPE_CRASHED = 2 [(metalstack.api.v2.enum_string_value) = "Crashed"]; | ||
| // PROVISIONING_EVENT_TYPE_PXE_BOOTING is sent when an unprovisioned machine requests a boot image via PXE | ||
| PROVISIONING_EVENT_TYPE_PXE_BOOTING = 3 [(metalstack.api.v2.enum_string_value) = "PXE Booting"]; | ||
| // PROVISIONING_EVENT_TYPE_PLANNED_REBOOT means the machine was scheduled for reboot | ||
| PROVISIONING_EVENT_TYPE_PLANNED_REBOOT = 4 [(metalstack.api.v2.enum_string_value) = "Planned Reboot"]; | ||
| // PROVISIONING_EVENT_TYPE_PREPARING means the metal-hammer has started | ||
| PROVISIONING_EVENT_TYPE_PREPARING = 5 [(metalstack.api.v2.enum_string_value) = "Preparing"]; | ||
| // PROVISIONING_EVENT_TYPE_REGISTERING means the metal-hammer is attempting to register the machine at the API | ||
| PROVISIONING_EVENT_TYPE_REGISTERING = 6 [(metalstack.api.v2.enum_string_value) = "Registering"]; | ||
| // PROVISIONING_EVENT_TYPE_WAITING means the machine has successfully reached the state where it is waiting for allocation | ||
| PROVISIONING_EVENT_TYPE_WAITING = 7 [(metalstack.api.v2.enum_string_value) = "Waiting"]; | ||
| // PROVISIONING_EVENT_TYPE_INSTALLING means the machine was allocated and the requested OS is being installed | ||
| PROVISIONING_EVENT_TYPE_INSTALLING = 8 [(metalstack.api.v2.enum_string_value) = "Installing"]; | ||
| // PROVISIONING_EVENT_TYPE_BOOTING_NEW_KERNEL means the machine has successfully been installed and is now booting into the new OS | ||
| PROVISIONING_EVENT_TYPE_BOOTING_NEW_KERNEL = 9 [(metalstack.api.v2.enum_string_value) = "Booting New Kernel"]; | ||
| // PROVISIONING_EVENT_TYPE_PHONED_HOME is sent periodically by an allocated machine to indicate its liveliness | ||
| PROVISIONING_EVENT_TYPE_PHONED_HOME = 10 [(metalstack.api.v2.enum_string_value) = "Phoned Home"]; | ||
| // PROVISIONING_EVENT_TYPE_MACHINE_RECLAIM means the machine was freed and is about to return into the pool of waiting machines | ||
| PROVISIONING_EVENT_TYPE_MACHINE_RECLAIM = 11 [(metalstack.api.v2.enum_string_value) = "Machine Reclaim"]; | ||
| } |
majst01
commented
May 23, 2026
Contributor
Author
There was a problem hiding this comment.
can be removed, only for reference
1 task
Gerrit91
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Really useful findings fixed now
Used AI-Tools ✨
Prompt: please identify inconsistencies and logical problems and write them into findings.md