Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in types.Skip the MAP branch skips the value with self.Skip(valueType), which re-enters through SkipDefaultDepth at DEFAULT_RECURSION_DEPTH instead of maxDepth-1, so the depth guard resets on every map value and never trips for map-value nesting (the key/set/list/struct branches all decrement via Skip(self, ..., maxDepth-1)); a ~60MB frame of nested map<byte, map<...>>, well under MaxFrameSize, then recurses until the goroutine stack overflows and the process dies with
fatal error: stack overflow, reachable pre-auth from the unknown-method skip path in process(). decrement depth on the value like the key already does, matching the java/rust skip helpers, so deep nesting hits DEPTH_LIMIT at 64 across all four formats.