Rename the image decoders' OutputDtype to ImageOutputDtypeConfig - #1699
Open
NicolasHug wants to merge 1 commit into
Open
Rename the image decoders' OutputDtype to ImageOutputDtypeConfig#1699NicolasHug wants to merge 1 commit into
NicolasHug wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1699
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 89c1ff4 with merge base 2312413 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
changed the base branch from
output-dtype-config-only
to
nvdec-surface-depth
September 4, 2026 09:27
NicolasHug
force-pushed
the
image-output-dtype-config
branch
2 times, most recently
from
September 4, 2026 10:02
a8c154c to
e580830
Compare
ImageCommon.h declared facebook::torchcodec::OutputDtype {UINT8, UINT16,
AUTO} and StreamOptions.h declares facebook::torchcodec::OutputDtype
{UINT8, FLOAT32}: two different types with one fully-qualified name. They
compile today only because no translation unit includes both headers - the
image decoders are FFmpeg-free and pull in neither StreamOptions.h nor
FFMPEGCommon.h nor Frame.h - which makes it a trap for whoever first makes
those worlds touch.
The image one is the odd name rather than the odd type: it carries AUTO and
is resolved at the point of use by should_output_uint16(), so it is a
config, and it is the counterpart of OutputDtypeConfig rather than of
OutputDtype. The int64 codes crossing the op boundary are unchanged, so
_validate_output_dtype on the Python side needs nothing.
NicolasHug
force-pushed
the
image-output-dtype-config
branch
from
September 4, 2026 10:18
e580830 to
89c1ff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageCommon.h declared facebook::torchcodec::OutputDtype {UINT8, UINT16,
AUTO} and StreamOptions.h declares facebook::torchcodec::OutputDtype
{UINT8, FLOAT32}: two different types with one fully-qualified name. They
compile today only because no translation unit includes both headers - the
image decoders are FFmpeg-free and pull in neither StreamOptions.h nor
FFMPEGCommon.h nor Frame.h - which makes it a trap for whoever first makes
those worlds touch.
The image one is the odd name rather than the odd type: it carries AUTO and
is resolved at the point of use by should_output_uint16(), so it is a
config, and it is the counterpart of OutputDtypeConfig rather than of
OutputDtype. The int64 codes crossing the op boundary are unchanged, so
_validate_output_dtype on the Python side needs nothing.
Stack created with GitHub Stacks CLI • Give Feedback 💬