Let the Demuxer read straight into the packet it hands out

[NicolasHug]

next_packet() has to return a packet the caller owns indefinitely: the
Python-level Packet can be held, moved to another thread, and decoded much
later. That is a UniqueAVPacket, and the AutoAVPacket / ReferenceAVPacket
pair is for the opposite thing - a loop that reuses one allocation and
unrefs at the end of each iteration.

So next_packet() was using the loop idiom and then undoing it: it read into
the shared packet, allocated a second one anyway, and moved the reference
across. Neither half of the idiom paid for itself - the allocation isn't
saved, and av_packet_move_ref() leaves the source blank so the scope-exit
unref has nothing to do.

read_next_packet() has no opinion on how the packet is owned, it just needs
somewhere to write, so it takes the AVPacket itself. Its callers keep the
ownership type that suits them: a ReferenceAVPacket for the two read loops
(SingleStreamDecoder and scan), a UniqueAVPacket for next_packet(). It also
unrefs between iterations, which av_read_frame() documents as the caller's
job rather than something it does for you.

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1695

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 Cancelled Jobs, 1 Unclassified Failure

As of commit 2d404db with merge base 2312413 ():

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

• Linux CUDA x86 / install-and-test (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)

CANCELLED JOBS - The following jobs were cancelled. Please retry:

• Linux CUDA x86 / build-docs (gh)
• Linux CUDA x86 / doc-preview (gh)
• Linux CUDA x86 / generate-matrix / generate (gh)
• Linux CUDA x86 / install-and-test-no-ffmpeg (gh)
• Linux CUDA x86 / install-and-test-on-cpu-only-machine (gh)
• Linux CUDA x86 / upload-docs (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.