Use average frame rate for video metadata - #1628
Open
mavenlin wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1628
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mavenlin
force-pushed
the
agent/use-average-frame-rate
branch
from
August 14, 2026 05:48
4692b7d to
518a2fd
Compare
mavenlin
force-pushed
the
agent/use-average-frame-rate
branch
from
August 14, 2026 06:02
518a2fd to
1a4e2f7
Compare
mavenlin
marked this pull request as ready for review
August 14, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
average_fps_from_headerfrom FFmpeg’sAVStream::avg_frame_rateinstead ofr_frame_rateWhy
r_frame_rateis FFmpeg’s estimate of the lowest-frequency regular grid that can represent all frame timestamps accurately, the coarsest sufficient grid.The regression test first asserts that ffprobe reports different values for the two fields, then compares TorchCodec against ffprobe’s
avg_frame_rateand away from itsr_frame_rate.Fixture generation
The fixture uses the 480×270 stream from
test/resources/nasa_13013.mp4, preserving source timestamps while selecting every second frame for the first 60 source frames and every third frame afterward.ffmpeg -i test/resources/nasa_13013.mp4 -map 0:v:1 -t 4 \ -vf "select=if(lt(n\,60)\,not(mod(n\,2))\,not(mod(n\,3)))" \ -fps_mode vfr -c:v libx264 -pix_fmt yuv420p -an \ test/resources/nasa_13013_vfr.mp4